From 0a29e90701ff2a01cad43bdcfbf46cd6b121679e Mon Sep 17 00:00:00 2001 From: snipe Date: Wed, 30 Apr 2025 15:24:42 +0100 Subject: [PATCH] Smal improvements to scoping displays Signed-off-by: snipe --- app/Http/Controllers/Api/ReportsController.php | 5 ++++- app/Presenters/LocationPresenter.php | 2 +- app/Providers/AuthServiceProvider.php | 9 +++++++++ resources/views/dashboard.blade.php | 2 +- 4 files changed, 15 insertions(+), 3 deletions(-) diff --git a/app/Http/Controllers/Api/ReportsController.php b/app/Http/Controllers/Api/ReportsController.php index 494c75104..c03dddf6b 100644 --- a/app/Http/Controllers/Api/ReportsController.php +++ b/app/Http/Controllers/Api/ReportsController.php @@ -5,6 +5,8 @@ namespace App\Http\Controllers\Api; use App\Http\Controllers\Controller; use App\Http\Transformers\ActionlogsTransformer; use App\Models\Actionlog; +use App\Models\Company; +use App\Models\Setting; use Illuminate\Http\Request; use Illuminate\Http\JsonResponse; @@ -18,10 +20,11 @@ class ReportsController extends Controller */ public function index(Request $request) : JsonResponse | array { - $this->authorize('reports.view'); + $this->authorize('activity.view'); $actionlogs = Actionlog::with('item', 'user', 'adminuser', 'target', 'location'); + if ($request->filled('search')) { $actionlogs = $actionlogs->TextSearch(e($request->input('search'))); } diff --git a/app/Presenters/LocationPresenter.php b/app/Presenters/LocationPresenter.php index 073918ce1..af02aa242 100644 --- a/app/Presenters/LocationPresenter.php +++ b/app/Presenters/LocationPresenter.php @@ -33,7 +33,7 @@ class LocationPresenter extends Presenter 'switchable' => true, 'title' => trans('general.company'), 'visible' => false, - 'formatter' => 'locationCompanyObjFilterFormatter' + 'formatter' => 'companiesLinkObjFormatter' ], [ 'field' => 'name', diff --git a/app/Providers/AuthServiceProvider.php b/app/Providers/AuthServiceProvider.php index 0d86cbdf6..899df2ef1 100644 --- a/app/Providers/AuthServiceProvider.php +++ b/app/Providers/AuthServiceProvider.php @@ -168,6 +168,15 @@ class AuthServiceProvider extends ServiceProvider } }); + // ----------------------------------------- + // Activity + // ----------------------------------------- + Gate::define('activity.view', function ($user) { + if (($user->hasAccess('reports.view')) || ($user->hasAccess('admin'))) { + return true; + } + }); + // ----------------------------------------- // Self // ----------------------------------------- diff --git a/resources/views/dashboard.blade.php b/resources/views/dashboard.blade.php index ff35d8445..d0fa06cf5 100755 --- a/resources/views/dashboard.blade.php +++ b/resources/views/dashboard.blade.php @@ -292,7 +292,7 @@
- @if ($snipeSettings->full_multiple_companies_support=='1') + @if ((($snipeSettings->scope_locations_fmcs!='1') && ($snipeSettings->full_multiple_companies_support=='1')))