From 4f08b2360cd5cdaab483dc09ebbf6c496fcee288 Mon Sep 17 00:00:00 2001 From: Marcus Moore Date: Mon, 27 Jan 2025 13:36:59 -0800 Subject: [PATCH 01/54] Migrate radios on custom report page --- resources/views/reports/custom.blade.php | 29 ++++++++++++++++++++---- 1 file changed, 25 insertions(+), 4 deletions(-) diff --git a/resources/views/reports/custom.blade.php b/resources/views/reports/custom.blade.php index 3ab43ed6b..3a2d5b254 100644 --- a/resources/views/reports/custom.blade.php +++ b/resources/views/reports/custom.blade.php @@ -581,15 +581,36 @@
From ac925af3d072a35909009838453b92bb0a458a24 Mon Sep 17 00:00:00 2001 From: Marcus Moore Date: Mon, 27 Jan 2025 13:50:22 -0800 Subject: [PATCH 02/54] Replace a few radio inputs on bulk user edit page --- resources/views/users/bulk-edit.blade.php | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/resources/views/users/bulk-edit.blade.php b/resources/views/users/bulk-edit.blade.php index 19b24bbe8..6d4a09f59 100644 --- a/resources/views/users/bulk-edit.blade.php +++ b/resources/views/users/bulk-edit.blade.php @@ -125,15 +125,15 @@
From eb4aeb47c154667c42d359c3624e0a45f8f62743 Mon Sep 17 00:00:00 2001 From: Marcus Moore Date: Thu, 30 Jan 2025 15:36:38 -0800 Subject: [PATCH 03/54] Replace Form::radio in top section of group permissions page --- resources/views/groups/edit.blade.php | 16 ++++++++++++++-- 1 file changed, 14 insertions(+), 2 deletions(-) diff --git a/resources/views/groups/edit.blade.php b/resources/views/groups/edit.blade.php index cb95b3762..62a1be277 100755 --- a/resources/views/groups/edit.blade.php +++ b/resources/views/groups/edit.blade.php @@ -88,11 +88,23 @@ - {{ Form::radio('permission['.$localPermission['permission'].']', '1',(array_key_exists($localPermission['permission'], $groupPermissions) ? $groupPermissions[$localPermission['permission'] ] == '1' : null),['value'=>"grant", 'aria-label'=> 'permission['.$localPermission['permission'].']']) }} + - {{ Form::radio('permission['.$localPermission['permission'].']', '0',(array_key_exists($localPermission['permission'], $groupPermissions) ? $groupPermissions[$localPermission['permission'] ] == '0' : null),['value'=>"grant", 'aria-label'=> 'permission['.$localPermission['permission'].']']) }} + From bf96688aef9c4ce1b89de5fae560606c97e0bee4 Mon Sep 17 00:00:00 2001 From: Marcus Moore Date: Thu, 30 Jan 2025 15:37:05 -0800 Subject: [PATCH 04/54] Re-order parameters --- resources/views/groups/edit.blade.php | 12 ++++++------ 1 file changed, 6 insertions(+), 6 deletions(-) diff --git a/resources/views/groups/edit.blade.php b/resources/views/groups/edit.blade.php index 62a1be277..171ffcff3 100755 --- a/resources/views/groups/edit.blade.php +++ b/resources/views/groups/edit.blade.php @@ -89,21 +89,21 @@ From 6fb83d66a2562f424c1c104293c012440a0e408e Mon Sep 17 00:00:00 2001 From: Marcus Moore Date: Thu, 30 Jan 2025 15:46:22 -0800 Subject: [PATCH 05/54] Revert "Re-order parameters" This reverts commit bf96688aef9c4ce1b89de5fae560606c97e0bee4. --- resources/views/groups/edit.blade.php | 12 ++++++------ 1 file changed, 6 insertions(+), 6 deletions(-) diff --git a/resources/views/groups/edit.blade.php b/resources/views/groups/edit.blade.php index 171ffcff3..62a1be277 100755 --- a/resources/views/groups/edit.blade.php +++ b/resources/views/groups/edit.blade.php @@ -89,21 +89,21 @@ From 0e390f1a9b4398e6224899c6e5f8fa6b824e9be8 Mon Sep 17 00:00:00 2001 From: Marcus Moore Date: Thu, 30 Jan 2025 15:54:27 -0800 Subject: [PATCH 06/54] Temporarily order properties --- resources/views/groups/edit.blade.php | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/resources/views/groups/edit.blade.php b/resources/views/groups/edit.blade.php index 62a1be277..6cd4c0aca 100755 --- a/resources/views/groups/edit.blade.php +++ b/resources/views/groups/edit.blade.php @@ -91,9 +91,9 @@ @@ -101,9 +101,9 @@ From 8dd432c3a2894d379fd13d590a3ac25c0b3bfeaf Mon Sep 17 00:00:00 2001 From: Marcus Moore Date: Thu, 30 Jan 2025 15:56:08 -0800 Subject: [PATCH 07/54] Convert section headings --- resources/views/groups/edit.blade.php | 16 ++++++++++++++-- 1 file changed, 14 insertions(+), 2 deletions(-) diff --git a/resources/views/groups/edit.blade.php b/resources/views/groups/edit.blade.php index 6cd4c0aca..7a3c87403 100755 --- a/resources/views/groups/edit.blade.php +++ b/resources/views/groups/edit.blade.php @@ -121,11 +121,23 @@ - {{ Form::radio("$area", '1',false,['value'=>"grant", 'data-checker-group' => str_slug($area), 'aria-label'=> $area]) }} + - {{ Form::radio("$area", '0',false,['value'=>"deny", 'data-checker-group' => str_slug($area), 'aria-label'=> $area]) }} + From 26b4063435fd598e055d40860f7bad971b1d9a97 Mon Sep 17 00:00:00 2001 From: Marcus Moore Date: Thu, 30 Jan 2025 16:07:46 -0800 Subject: [PATCH 08/54] Convert section items --- resources/views/groups/edit.blade.php | 17 +++++++++++++++-- 1 file changed, 15 insertions(+), 2 deletions(-) diff --git a/resources/views/groups/edit.blade.php b/resources/views/groups/edit.blade.php index 7a3c87403..83615381b 100755 --- a/resources/views/groups/edit.blade.php +++ b/resources/views/groups/edit.blade.php @@ -153,11 +153,24 @@ - {{ Form::radio('permission['.$this_permission['permission'].']', '1',(array_key_exists($this_permission['permission'], $groupPermissions) ? $groupPermissions[$this_permission['permission'] ] == '1' : null),['class'=>'radiochecker-'.str_slug($area), 'aria-label'=>'permission['.$this_permission['permission'].']']) }} + - {{ Form::radio('permission['.$this_permission['permission'].']', '0',(array_key_exists($this_permission['permission'], $groupPermissions) ? $groupPermissions[$this_permission['permission'] ] == '0' : null),['class'=>'radiochecker-'.str_slug($area), 'aria-label'=>'permission['.$this_permission['permission'].']']) }} + From ddc22b4d6b680bf6bad34241f165ade49608b401 Mon Sep 17 00:00:00 2001 From: Godfrey M Date: Mon, 3 Feb 2025 10:38:49 -0800 Subject: [PATCH 09/54] adds a check to see that qr code type is not none --- app/Http/Controllers/Assets/AssetsController.php | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/app/Http/Controllers/Assets/AssetsController.php b/app/Http/Controllers/Assets/AssetsController.php index 6fd27ed03..8f3b1f054 100755 --- a/app/Http/Controllers/Assets/AssetsController.php +++ b/app/Http/Controllers/Assets/AssetsController.php @@ -535,7 +535,7 @@ class AssetsController extends Controller { $settings = Setting::getSettings(); - if ($settings->qr_code == '1') { + if (($settings->qr_code === '1') && ($settings->label2_2d_type !== 'none')) { $asset = Asset::withTrashed()->find($assetId); if ($asset) { $size = Helper::barcodeDimensions($settings->label2_2d_type); From 24bb6793053fb01748eb317fb2bbfe0750e0ef99 Mon Sep 17 00:00:00 2001 From: Godfrey M Date: Mon, 3 Feb 2025 12:24:22 -0800 Subject: [PATCH 10/54] adds check that asset has asset status before checking archived --- app/Notifications/CheckinAssetNotification.php | 2 +- resources/views/locations/print.blade.php | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/app/Notifications/CheckinAssetNotification.php b/app/Notifications/CheckinAssetNotification.php index fa4780c1f..024298117 100644 --- a/app/Notifications/CheckinAssetNotification.php +++ b/app/Notifications/CheckinAssetNotification.php @@ -143,7 +143,7 @@ class CheckinAssetNotification extends Notification KeyValue::create( trans('mail.checked_into') ?: '', $item->location->name ? $item->location->name : '', - trans('admin/hardware/form.status').": ".$item->assetstatus->name, + trans('admin/hardware/form.status').": ".$item->assetstatus?->name, ) ->onClick(route('hardware.show', $item->id)) ) diff --git a/resources/views/locations/print.blade.php b/resources/views/locations/print.blade.php index 9f54978ff..a047f0227 100644 --- a/resources/views/locations/print.blade.php +++ b/resources/views/locations/print.blade.php @@ -126,7 +126,7 @@ @foreach ($assets as $asset) @php - if($snipeSettings->show_archived_in_list != 1 && $asset->assetstatus->archived == 1){ + if($snipeSettings->show_archived_in_list != 1 && $asset->assetstatus?->archived == 1){ continue; } @endphp From 6bb0927f262b19d2f0126c6d0cf464d457b66bc2 Mon Sep 17 00:00:00 2001 From: Godfrey M Date: Mon, 3 Feb 2025 12:30:21 -0800 Subject: [PATCH 11/54] remove unrelated change --- app/Notifications/CheckinAssetNotification.php | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/app/Notifications/CheckinAssetNotification.php b/app/Notifications/CheckinAssetNotification.php index 024298117..fa4780c1f 100644 --- a/app/Notifications/CheckinAssetNotification.php +++ b/app/Notifications/CheckinAssetNotification.php @@ -143,7 +143,7 @@ class CheckinAssetNotification extends Notification KeyValue::create( trans('mail.checked_into') ?: '', $item->location->name ? $item->location->name : '', - trans('admin/hardware/form.status').": ".$item->assetstatus?->name, + trans('admin/hardware/form.status').": ".$item->assetstatus->name, ) ->onClick(route('hardware.show', $item->id)) ) From 295875c45e9a24069c512523ffc289c34e20d58d Mon Sep 17 00:00:00 2001 From: Marcus Moore Date: Tue, 4 Feb 2025 11:02:40 -0800 Subject: [PATCH 12/54] Fix and replace remaining radios on bulk user edit page --- resources/views/users/bulk-edit.blade.php | 28 +++++++++++------------ 1 file changed, 14 insertions(+), 14 deletions(-) diff --git a/resources/views/users/bulk-edit.blade.php b/resources/views/users/bulk-edit.blade.php index 6d4a09f59..5909e4a25 100644 --- a/resources/views/users/bulk-edit.blade.php +++ b/resources/views/users/bulk-edit.blade.php @@ -124,8 +124,8 @@
-
-
@@ -170,15 +170,15 @@
@@ -192,16 +192,16 @@
-