lunax/snipe_it
1
0
Fork 0
Code Issues Pull requests Projects Releases Wiki Activity Actions

Reduce SAML debugging output to actual error conditions

Browse source
This commit is contained in:
Brady Wetherington 2022-05-17 19:54:14 -07:00
parent 137b558bef
commit 4e65a8d755
1 changed files with 3 additions and 3 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

6
app/Services/Saml.php
View file

@ -130,11 +130,12 @@ class Saml
$this->clearData(); $this->clearData();
} }
\Log::debug('Trying to create a new OneLogin_Saml2_Auth object ');
try { try {
$this->_auth = new OneLogin_Saml2_Auth($this->_settings); $this->_auth = new OneLogin_Saml2_Auth($this->_settings);
} catch (Exception $e) { } catch (Exception $e) {
\Log::error('Trying OneLogin_Saml2_Auth failed. Setting SAML enabled to false. OneLogin_Saml2_Auth error message is: '. $e->getMessage()); if ( $this->isEnabled() ) { // $this->loadSettings() initializes this to true if SAML is enabled by settings.
\Log::error('Trying OneLogin_Saml2_Auth failed. Setting SAML enabled to false. OneLogin_Saml2_Auth error message is: '. $e->getMessage());
}
$this->_enabled = false; $this->_enabled = false;
} }
} }
@ -157,7 +158,6 @@ class Saml
$this->_enabled = $setting->saml_enabled == '1'; $this->_enabled = $setting->saml_enabled == '1';
if ($this->isEnabled()) { if ($this->isEnabled()) {
\Log::debug('SAML is enabled according to loadSettings()');
//Let onelogin/php-saml know to use 'X-Forwarded-*' headers if it is from a trusted proxy //Let onelogin/php-saml know to use 'X-Forwarded-*' headers if it is from a trusted proxy
OneLogin_Saml2_Utils::setProxyVars(request()->isFromTrustedProxy()); OneLogin_Saml2_Utils::setProxyVars(request()->isFromTrustedProxy());