Update tests

This commit is contained in:
Marcus Moore 2023-12-20 16:37:27 -08:00
parent 9a5c8c4ce6
commit 578495bab6
No known key found for this signature in database
2 changed files with 9 additions and 9 deletions

View file

@ -15,7 +15,7 @@ class ReportTemplateFactory extends Factory
{ {
return [ return [
'name' => $this->faker->word(), 'name' => $this->faker->word(),
'options' => json_encode([]), 'options' => [],
]; ];
} }
} }

View file

@ -22,34 +22,34 @@ class ReportTemplateTest extends TestCase
}]); }]);
} }
public function testCanLoadASavedCustomReport() public function testCanLoadASavedReportTemplate()
{ {
$user = User::factory()->canViewReports()->create(); $user = User::factory()->canViewReports()->create();
$reportTemplate = ReportTemplate::factory()->make(['name' => 'My Awesome Report']); $reportTemplate = ReportTemplate::factory()->make(['name' => 'My Awesome Template']);
$user->reportTemplates()->save($reportTemplate); $user->reportTemplates()->save($reportTemplate);
$this->actingAs($user) $this->actingAs($user)
->get(route('reports/custom', ['report' => $reportTemplate->id])) ->get(route('report-templates.show', $reportTemplate))
->assertOk() ->assertOk()
->assertViewHas(['reportTemplate' => function (ReportTemplate $viewReport) use ($reportTemplate) { ->assertViewHas(['reportTemplate' => function (ReportTemplate $viewReport) use ($reportTemplate) {
return $viewReport->is($reportTemplate); return $viewReport->is($reportTemplate);
}]); }]);
} }
public function testCanSaveACustomReport() public function testCanSaveAReportTemplate()
{ {
$user = User::factory()->canViewReports()->create(); $user = User::factory()->canViewReports()->create();
$this->actingAs($user) $this->actingAs($user)
->post(route('report-templates.store'), [ ->post(route('report-templates.store'), [
'name' => 'My Awesome Report', 'name' => 'My Awesome Template',
'company' => '1', 'company' => '1',
'by_company_id' => ['1', '2'], 'by_company_id' => ['1', '2'],
]) ])
->assertRedirect(); ->assertRedirect();
$template = $user->reportTemplates->first(function ($report) { $template = $user->reportTemplates->first(function ($report) {
return $report->name === 'My Awesome Report'; return $report->name === 'My Awesome Template';
}); });
$this->assertNotNull($template); $this->assertNotNull($template);
@ -57,7 +57,7 @@ class ReportTemplateTest extends TestCase
$this->assertEquals(['1', '2'], $template->options['by_company_id']); $this->assertEquals(['1', '2'], $template->options['by_company_id']);
} }
public function testSavingReportRequiresValidFields() public function testReportTemplateRequiresValidFields()
{ {
$this->actingAs(User::factory()->canViewReports()->create()) $this->actingAs(User::factory()->canViewReports()->create())
->post(route('report-templates.store'), [ ->post(route('report-templates.store'), [
@ -66,7 +66,7 @@ class ReportTemplateTest extends TestCase
->assertSessionHasErrors('name'); ->assertSessionHasErrors('name');
} }
public function testSavingReportRequiresCorrectPermission() public function testSavingReportTemplateRequiresCorrectPermission()
{ {
$this->actingAs(User::factory()->create()) $this->actingAs(User::factory()->create())
->post(route('report-templates.store')) ->post(route('report-templates.store'))