diff --git a/app/Http/Controllers/Users/BulkUsersController.php b/app/Http/Controllers/Users/BulkUsersController.php index cd6d67983..d07d25f54 100644 --- a/app/Http/Controllers/Users/BulkUsersController.php +++ b/app/Http/Controllers/Users/BulkUsersController.php @@ -5,10 +5,13 @@ namespace App\Http\Controllers\Users; use App\Helpers\Helper; use App\Http\Controllers\Controller; use App\Models\Accessory; +use App\Models\License; use App\Models\Actionlog; use App\Models\Asset; use App\Models\Group; use App\Models\LicenseSeat; +use App\Models\ConsumableAssignment; +use App\Models\Consumable; use App\Models\User; use Illuminate\Http\Request; use Illuminate\Support\Facades\Auth; @@ -162,13 +165,11 @@ class BulkUsersController extends Controller if ((! $request->filled('ids')) || (count($request->input('ids')) == 0)) { return redirect()->back()->with('error', 'No users selected'); } - if ((! $request->filled('status_id')) || ($request->input('status_id') == '')) { - return redirect()->route('users.index')->with('error', 'No status selected'); - } if (config('app.lock_passwords')) { return redirect()->route('users.index')->with('error', 'Bulk delete is not enabled in this installation'); } + $user_raw_array = request('ids'); if (($key = array_search(Auth::id(), $user_raw_array)) !== false) { @@ -179,11 +180,18 @@ class BulkUsersController extends Controller $assets = Asset::whereIn('assigned_to', $user_raw_array)->where('assigned_type', \App\Models\User::class)->get(); $accessories = DB::table('accessories_users')->whereIn('assigned_to', $user_raw_array)->get(); $licenses = DB::table('license_seats')->whereIn('assigned_to', $user_raw_array)->get(); + $consumables = DB::table('consumables_users')->whereIn('assigned_to', $user_raw_array)->get(); + + if ((($assets->count() > 0) && ((!$request->filled('status_id')) || ($request->input('status_id') == '')))) { + return redirect()->route('users.index')->with('error', 'No status selected'); + } $this->logItemCheckinAndDelete($assets, Asset::class); $this->logItemCheckinAndDelete($accessories, Accessory::class); - $this->logItemCheckinAndDelete($licenses, LicenseSeat::class); + $this->logItemCheckinAndDelete($licenses, License::class); + $this->logItemCheckinAndDelete($consumables, Consumable::class); + Asset::whereIn('id', $assets->pluck('id'))->update([ 'status_id' => e(request('status_id')), @@ -193,13 +201,26 @@ class BulkUsersController extends Controller LicenseSeat::whereIn('id', $licenses->pluck('id'))->update(['assigned_to' => null]); + ConsumableAssignment::whereIn('id', $consumables->pluck('id'))->delete(); + foreach ($users as $user) { + + $user->consumables()->sync([]); $user->accessories()->sync([]); - $user->delete(); + if ($request->input('delete_user')=='1') { + $user->delete(); + } + } - return redirect()->route('users.index')->with('success', 'Your selected users have been deleted and their assets have been updated.'); + $msg = trans('general.bulk_checkin_success'); + if ($request->input('delete_user')=='1') { + $msg = trans('general.bulk_checkin_delete_success'); + } + + + return redirect()->route('users.index')->with('success', $msg); } /** @@ -217,7 +238,7 @@ class BulkUsersController extends Controller $logAction->target_id = $item->assigned_to; $logAction->target_type = User::class; $logAction->user_id = Auth::id(); - $logAction->note = 'Bulk checkin items and delete user'; + $logAction->note = 'Bulk checkin items'; $logAction->logaction('checkin from'); } } diff --git a/resources/lang/en/admin/users/general.php b/resources/lang/en/admin/users/general.php index c77ff8f8c..daa568e8b 100644 --- a/resources/lang/en/admin/users/general.php +++ b/resources/lang/en/admin/users/general.php @@ -34,7 +34,7 @@ return [ 'admin_permission_warning' => 'Only users with admins rights or greater may grant a user admin access.', 'remove_group_memberships' => 'Remove Group Memberships', 'warning_deletion' => 'WARNING:', - 'warning_deletion_information' => 'You are about to delete the :count user(s) listed below. Super admin names are highlighted in red.', + 'warning_deletion_information' => 'You are about to checkin ALL items from the :count user(s) listed below. Super admin names are highlighted in red.', 'update_user_assets_status' => 'Update all assets for these users to this status', 'checkin_user_properties' => 'Check in all properties associated with these users', 'remote_label' => 'This is a remote user', diff --git a/resources/lang/en/button.php b/resources/lang/en/button.php index 1e44af7d1..22821b815 100644 --- a/resources/lang/en/button.php +++ b/resources/lang/en/button.php @@ -4,7 +4,7 @@ return [ 'actions' => 'Actions', 'add' => 'Add New', 'cancel' => 'Cancel', - 'checkin_and_delete' => 'Checkin & Delete User', + 'checkin_and_delete' => 'Checkin All / Delete User', 'delete' => 'Delete', 'edit' => 'Edit', 'restore' => 'Restore', diff --git a/resources/lang/en/general.php b/resources/lang/en/general.php index 9b1380f25..43e9e4fbe 100644 --- a/resources/lang/en/general.php +++ b/resources/lang/en/general.php @@ -37,7 +37,7 @@ return [ 'bulk_edit' => 'Bulk Edit', 'bulk_delete' => 'Bulk Delete', 'bulk_actions' => 'Bulk Actions', - 'bulk_checkin_delete' => 'Bulk Checkin & Delete', + 'bulk_checkin_delete' => 'Bulk Checkin Items from Users', 'bystatus' => 'by Status', 'cancel' => 'Cancel', 'categories' => 'Categories', @@ -365,5 +365,9 @@ return [ 'backup_delete_not_allowed' => 'Deleting backups has been disabled in the .env file. Contact support or your systems administrator.', 'additional_files' => 'Additional Files', 'shitty_browser' => 'No signature detected. If you are using an older browser, please use a more modern browser to complete your asset acceptance.', + 'bulk_soft_delete' =>'Also soft-delete these users. Their asset history will remain intact unless/until you purge deleted records in the Admin Settings.', + 'bulk_checkin_delete_success' => 'Your selected users have been deleted and their items have been checked in.', + 'bulk_checkin_success' => 'The items for the selected users have been checked in.', + ]; \ No newline at end of file diff --git a/resources/views/users/confirm-bulk-delete.blade.php b/resources/views/users/confirm-bulk-delete.blade.php index bdc084fde..d5dcac3e1 100644 --- a/resources/views/users/confirm-bulk-delete.blade.php +++ b/resources/views/users/confirm-bulk-delete.blade.php @@ -26,7 +26,7 @@ @if (config('app.lock_passwords'))
{{ trans('feature_disabled') }}
+{{ trans('general.feature_disabled') }}