From e06e4db4b71939b35d88e5e4f326d9f5bb9b70d0 Mon Sep 17 00:00:00 2001
From: snipe <snipe@snipe.net>
Date: Sat, 13 Jul 2024 18:16:03 +0100
Subject: [PATCH 1/2] Small layout tweaks to oauth page

Signed-off-by: snipe <snipe@snipe.net>
---
 resources/lang/en-US/account/general.php      |  1 +
 .../views/livewire/oauth-clients.blade.php    | 69 +++++++++++++++----
 2 files changed, 58 insertions(+), 12 deletions(-)

diff --git a/resources/lang/en-US/account/general.php b/resources/lang/en-US/account/general.php
index d99e36df8..4fe86164e 100644
--- a/resources/lang/en-US/account/general.php
+++ b/resources/lang/en-US/account/general.php
@@ -12,4 +12,5 @@ return array(
     'api_reference' => 'Please check the <a href="https://snipe-it.readme.io/reference" target="_blank">API reference</a> to find specific API endpoints and additional API documentation.',
     'profile_updated' => 'Account successfully updated',
     'no_tokens' => 'You have not created any personal access tokens.',
+    'expires' => 'Expires',
 );
diff --git a/resources/views/livewire/oauth-clients.blade.php b/resources/views/livewire/oauth-clients.blade.php
index 27a76b623..eeba0e686 100644
--- a/resources/views/livewire/oauth-clients.blade.php
+++ b/resources/views/livewire/oauth-clients.blade.php
@@ -32,14 +32,23 @@
                 @endif
 
             @if ($clients->count() > 0)
-                <table class="table table-striped snipe-table">
+                    <table data-cookie-id-table="OAuthClientsTable"
+                           data-pagination="true"
+                           data-id-table="OAuthClientsTable"
+                           data-side-pagination="client"
+                           data-sort-order="desc"
+                           data-sort-name="created_at"
+                           id="OAuthClientsTable"
+                           class="table table-striped snipe-table">
                     <thead>
                         <tr>
                             <th>{{ trans('general.id') }}</th>
-                            <th>{{ trans('general.name') }}</th>
-                            <th>{{ trans('admin/settings/general.oauth_redirect_url') }}</th>
-                            <th>{{ trans('admin/settings/general.oauth_secret') }}</th>
-                            <th><span class="sr-only">{{ trans('general.actions') }}</span></th>
+                            <th data-sortable="true">{{ trans('general.name') }}</th>
+                            <th data-sortable="true">{{ trans('admin/settings/general.oauth_redirect_url') }}</th>
+                            <th data-sortable="true">{{ trans('admin/settings/general.oauth_secret') }}</th>
+                            <th data-sortable="true">{{ trans('general.created_at')  }}</th>
+                            <th data-sortable="true">{{ trans('general.updated_at')  }}</th>
+                            <th data-sortable="true"><span class="sr-only">{{ trans('general.actions') }}</span></th>
                         </tr>
                     </thead>
                     <tbody>
@@ -57,7 +66,7 @@
 
                                 <!-- Redirect -->
                                 <td>
-                                    {{ $client->redirect }}
+                                    <code>{{ $client->redirect }}</code>
                                 </td>
 
                                 <!-- Secret -->
@@ -65,6 +74,16 @@
                                     <code>{{ $client->secret }}</code>
                                 </td>
 
+                                <td>
+                                    {{ $client->created_at ? Helper::getFormattedDateObject($client->created_at, 'datetime', false) : '' }}
+                                </td>
+
+                                <td>
+                                    @if ($client->created_at != $client->updated_at)
+                                        {{ $client->updated_at ? Helper::getFormattedDateObject($client->updated_at, 'datetime', false) : '' }}
+                                    @endif
+                                </td>
+
                                 <!-- Edit / Delete Button -->
                                 <td class="text-right">
 
@@ -77,8 +96,8 @@
                                     <a class="action-link btn btn-danger btn-sm" wire:click="deleteClient('{{ $client->id }}')">
                                         <i class="fas fa-trash" aria-hidden="true"></i>
                                         <span class="sr-only">
-                                                    {{ trans('general.delete') }}
-                                                </span>
+                                            {{ trans('general.delete') }}
+                                        </span>
                                     </a>
                                 </td>
                             </tr>
@@ -96,18 +115,29 @@
                 <div>
                     <div class="box box-default">
                         <div class="box-header">
-                            <h2>
+                            <h2  class="box-title">
                                 {{ trans('admin/settings/general.oauth_authorized_apps') }}
                             </h2>
                         </div>
 
                         <div class="box-body">
                             <!-- Authorized Tokens -->
-                            <table class="table table-striped snipe-table">
+                            <table data-cookie-id-table="AuthorizedAppsTale"
+                                   data-pagination="true"
+                                   data-id-table="AuthorizedAppsTale"
+                                   data-toolbar="#AuthorizedAppsToolbar"
+                                   data-side-pagination="client"
+                                   data-sort-order="desc"
+                                   data-sort-name="created_at"
+                                   id="AuthorizedAppsTale"
+                                   class="table table-striped snipe-table">
                                 <thead>
                                 <tr>
-                                    <th>{{ trans('general.name') }}</th>
-                                    <th>{{ trans('admin/settings/general.oauth_scopes')  }}</th>
+                                    <th data-sortable="true">{{ trans('general.name') }}</th>
+                                    <th data-sortable="true"> {{ trans('account/general.personal_access_token') }}</th>
+                                    <th data-sortable="true">{{ trans('admin/settings/general.oauth_scopes')  }}</th>
+                                    <th data-sortable="true">{{ trans('general.created_at')  }}</th>
+                                    <th data-sortable="true">{{ trans('account/general.expires')  }}</th>
                                     <th></th>
                                 </tr>
                                 </thead>
@@ -120,6 +150,10 @@
                                             {{ $token->client->name }}
                                         </td>
 
+                                        <td>
+                                            {{ $token->name }}
+                                        </td>
+
                                         <!-- Scopes -->
                                         <td>
                                             @if(!$token->scopes)
@@ -129,6 +163,13 @@
                                             @endif
                                         </td>
 
+                                        <td>
+                                            {{ $token->created_at ? Helper::getFormattedDateObject($token->created_at, 'datetime', false) : '' }}
+                                        </td>
+
+                                        <td>
+                                            {{ $token->expires_at ? Helper::getFormattedDateObject($token->expires_at, 'datetime', false) : '' }}
+                                        </td>
                                         <!-- Revoke Button -->
                                         <td>
                                             <a class="btn btn-sm btn-danger pull-right"
@@ -354,4 +395,8 @@
     </script>
 </div>
 
+@section('moar_scripts')
+    @include ('partials.bootstrap-table')
+@endsection
+
 

From 2d1aeca9494b9320e8412e8219b546e3d9e84bc5 Mon Sep 17 00:00:00 2001
From: snipe <snipe@snipe.net>
Date: Sat, 13 Jul 2024 18:24:56 +0100
Subject: [PATCH 2/2] Re-use existing string

Signed-off-by: snipe <snipe@snipe.net>
---
 resources/lang/en-US/account/general.php      |  1 -
 .../views/livewire/oauth-clients.blade.php    | 27 +++++++++++++------
 2 files changed, 19 insertions(+), 9 deletions(-)

diff --git a/resources/lang/en-US/account/general.php b/resources/lang/en-US/account/general.php
index 4fe86164e..d99e36df8 100644
--- a/resources/lang/en-US/account/general.php
+++ b/resources/lang/en-US/account/general.php
@@ -12,5 +12,4 @@ return array(
     'api_reference' => 'Please check the <a href="https://snipe-it.readme.io/reference" target="_blank">API reference</a> to find specific API endpoints and additional API documentation.',
     'profile_updated' => 'Account successfully updated',
     'no_tokens' => 'You have not created any personal access tokens.',
-    'expires' => 'Expires',
 );
diff --git a/resources/views/livewire/oauth-clients.blade.php b/resources/views/livewire/oauth-clients.blade.php
index eeba0e686..7caf5f6a2 100644
--- a/resources/views/livewire/oauth-clients.blade.php
+++ b/resources/views/livewire/oauth-clients.blade.php
@@ -48,7 +48,11 @@
                             <th data-sortable="true">{{ trans('admin/settings/general.oauth_secret') }}</th>
                             <th data-sortable="true">{{ trans('general.created_at')  }}</th>
                             <th data-sortable="true">{{ trans('general.updated_at')  }}</th>
-                            <th data-sortable="true"><span class="sr-only">{{ trans('general.actions') }}</span></th>
+                            <th>
+                                <span class="sr-only">
+                                    {{ trans('general.actions') }}
+                                </span>
+                            </th>
                         </tr>
                     </thead>
                     <tbody>
@@ -90,7 +94,10 @@
                                     <a class="action-link btn btn-sm btn-warning"
                                        wire:click="editClient('{{ $client->id }}')"
                                        onclick="$('#modal-edit-client').modal('show');">
-                                        <i class="fas fa-pencil-alt" aria-hidden="true"></i><span class="sr-only">{{ trans('general.update') }}</span>
+                                        <i class="fas fa-pencil-alt" aria-hidden="true"></i>
+                                        <span class="sr-only">
+                                            {{ trans('general.update') }}
+                                        </span>
                                     </a>
 
                                     <a class="action-link btn btn-danger btn-sm" wire:click="deleteClient('{{ $client->id }}')">
@@ -115,21 +122,21 @@
                 <div>
                     <div class="box box-default">
                         <div class="box-header">
-                            <h2  class="box-title">
+                            <h2 class="box-title">
                                 {{ trans('admin/settings/general.oauth_authorized_apps') }}
                             </h2>
                         </div>
 
                         <div class="box-body">
                             <!-- Authorized Tokens -->
-                            <table data-cookie-id-table="AuthorizedAppsTale"
+                            <table data-cookie-id-table="AuthorizedAppsTable"
                                    data-pagination="true"
-                                   data-id-table="AuthorizedAppsTale"
+                                   data-id-table="AuthorizedAppsTable"
                                    data-toolbar="#AuthorizedAppsToolbar"
                                    data-side-pagination="client"
                                    data-sort-order="desc"
                                    data-sort-name="created_at"
-                                   id="AuthorizedAppsTale"
+                                   id="AuthorizedAppsTable"
                                    class="table table-striped snipe-table">
                                 <thead>
                                 <tr>
@@ -137,8 +144,12 @@
                                     <th data-sortable="true"> {{ trans('account/general.personal_access_token') }}</th>
                                     <th data-sortable="true">{{ trans('admin/settings/general.oauth_scopes')  }}</th>
                                     <th data-sortable="true">{{ trans('general.created_at')  }}</th>
-                                    <th data-sortable="true">{{ trans('account/general.expires')  }}</th>
-                                    <th></th>
+                                    <th data-sortable="true">{{ trans('general.expires') }}</th>
+                                    <th>
+                                        <span class="sr-only">
+                                            {{ trans('general.actions') }}
+                                        </span>
+                                    </th>
                                 </tr>
                                 </thead>