diff --git a/app/Http/Controllers/Api/AssetsController.php b/app/Http/Controllers/Api/AssetsController.php index f587435b6..6f725cafb 100644 --- a/app/Http/Controllers/Api/AssetsController.php +++ b/app/Http/Controllers/Api/AssetsController.php @@ -545,7 +545,6 @@ class AssetsController extends Controller // @todo: verify eol is working as expected - move to request? or do I want this at all? // might just remove this and then use the method from here https://github.com/snipe/snipe-it/pull/13846 $asset->asset_eol_date = $request->validated()['asset_eol_date'] ?? $asset->present()->eol_date(); // so this isn't really necessary, because it's happening on the observer - but that might change? - $asset->physical = '1'; $asset->depreciate = '0'; /** diff --git a/app/Http/Controllers/Assets/AssetsController.php b/app/Http/Controllers/Assets/AssetsController.php index 6384e0f12..61b0959ae 100755 --- a/app/Http/Controllers/Assets/AssetsController.php +++ b/app/Http/Controllers/Assets/AssetsController.php @@ -131,7 +131,6 @@ class AssetsController extends Controller $asset->order_number = $request->input('order_number'); $asset->notes = $request->input('notes'); $asset->user_id = Auth::id(); - $asset->physical = '1'; $asset->depreciate = '0'; $asset->status_id = request('status_id'); $asset->warranty_months = request('warranty_months', null); @@ -364,7 +363,6 @@ class AssetsController extends Controller $asset->order_number = $request->input('order_number'); $asset->asset_tag = $asset_tag[1]; $asset->notes = $request->input('notes'); - $asset->physical = '1'; $asset = $request->handleImages($asset); diff --git a/app/Models/Asset.php b/app/Models/Asset.php index 9a696b22d..7daf73c3b 100644 --- a/app/Models/Asset.php +++ b/app/Models/Asset.php @@ -70,7 +70,6 @@ class Asset extends Depreciable protected $injectUniqueIdentifier = true; protected $casts = [ - 'physical' => 'boolean', 'purchase_date' => 'date', 'eol_explicit' => 'boolean', 'last_checkout' => 'datetime', @@ -96,7 +95,6 @@ class Asset extends Depreciable 'name' => 'nullable|max:255', 'company_id' => 'nullable|integer|exists:companies,id', 'warranty_months' => 'nullable|numeric|digits_between:0,240', - 'physical' => 'nullable|boolean', 'last_checkout' => 'nullable|date_format:Y-m-d H:i:s', 'expected_checkin' => 'nullable|date', 'location_id' => 'nullable|exists:locations,id', diff --git a/tests/Feature/Api/Assets/AssetStoreTest.php b/tests/Feature/Api/Assets/AssetStoreTest.php index 88f833afb..1584659d7 100644 --- a/tests/Feature/Api/Assets/AssetStoreTest.php +++ b/tests/Feature/Api/Assets/AssetStoreTest.php @@ -66,7 +66,6 @@ class AssetStoreTest extends TestCase $this->assertTrue($asset->adminuser->is($user)); - $this->assertTrue($asset->physical); // @todo: This isn't in the docs but it's in the controller $this->assertEquals('2024-06-02', $asset->asset_eol_date); $this->assertEquals('random_string', $asset->asset_tag);