From 67a9929745e11371a12b169a8b2317eac581961b Mon Sep 17 00:00:00 2001 From: snipe Date: Wed, 28 Aug 2024 11:56:54 +0100 Subject: [PATCH 01/11] Opens label new window Signed-off-by: snipe --- resources/views/hardware/view.blade.php | 1 + 1 file changed, 1 insertion(+) diff --git a/resources/views/hardware/view.blade.php b/resources/views/hardware/view.blade.php index 3c0847586..2d232df75 100755 --- a/resources/views/hardware/view.blade.php +++ b/resources/views/hardware/view.blade.php @@ -242,6 +242,7 @@ 'method' => 'POST', 'route' => ['hardware/bulkedit'], 'class' => 'form-inline', + 'target'=>'_blank', 'id' => 'bulkForm']) }} From b5a4389815cb133e645cd0efe68a2f14df110202 Mon Sep 17 00:00:00 2001 From: snipe Date: Wed, 28 Aug 2024 12:38:31 +0100 Subject: [PATCH 02/11] Added badge count, fixed model bulk edit menu Signed-off-by: snipe --- resources/views/depreciations/view.blade.php | 41 +++++++++++++++++--- 1 file changed, 35 insertions(+), 6 deletions(-) diff --git a/resources/views/depreciations/view.blade.php b/resources/views/depreciations/view.blade.php index d075a31e9..c836f8647 100644 --- a/resources/views/depreciations/view.blade.php +++ b/resources/views/depreciations/view.blade.php @@ -30,15 +30,38 @@
+
  • + + {{ trans('general.assets') }} + + {!! ($depreciation->assets()->AssetsForShow()->count() > 0 ) ? ''.number_format($depreciation->assets()->AssetsForShow()->count()).'' : '' !!} + +
    • +
  • + + {{ trans('general.licenses') }} + + {!! ($depreciation->licenses_count > 0 ) ? ''.number_format($depreciation->licenses_count).'' : '' !!} + +
    • +
  • + + {{ trans('general.asset_models') }} + + {!! ($depreciation->models_count > 0 ) ? ''.number_format($depreciation->models_count).'' : '' !!} + +
    • +
    + @include('partials.asset-bulk-actions', [ + 'id_divname' => 'assetsBulkEditToolbar', + 'id_formname' => 'assetsBulkForm', + 'id_button' => 'assetEditButton' + ]) 'POST', 'route' => ['models.bulkedit.index'], 'class' => 'form-inline', - 'id' => 'bulkForm'] + 'id' => 'bulkForm'] ) }}
    @@ -116,7 +143,7 @@ - +
    @@ -134,6 +161,8 @@ data-show-refresh="true" data-sort-order="asc" data-sort-name="name" + data-bulk-button-id="#AssetModelsBulkEditButton" + data-bulk-form-id="#bulkForm" class="table table-striped snipe-table" data-url="{{ route('api.models.index',['depreciation_id'=> $depreciation->id]) }}" data-export-options='{ From a5ff623484d066e7c29c0982a8e2df389142138c Mon Sep 17 00:00:00 2001 From: snipe Date: Wed, 28 Aug 2024 12:38:43 +0100 Subject: [PATCH 03/11] Added asset, license, model count to API Signed-off-by: snipe --- app/Presenters/DepreciationPresenter.php | 20 ++++++++++++++++++++ 1 file changed, 20 insertions(+) diff --git a/app/Presenters/DepreciationPresenter.php b/app/Presenters/DepreciationPresenter.php index 9df1fe132..cfba53162 100644 --- a/app/Presenters/DepreciationPresenter.php +++ b/app/Presenters/DepreciationPresenter.php @@ -46,6 +46,26 @@ class DepreciationPresenter extends Presenter "title" => trans('admin/depreciations/table.depreciation_min'), "visible" => true, ], + [ + 'field' => 'assets_count', + 'searchable' => false, + 'sortable' => true, + 'title' => trans('general.assets'), + 'visible' => true, + ], + [ + 'field' => 'models_count', + 'searchable' => false, + 'sortable' => true, + 'title' => trans('general.asset_models'), + 'visible' => true, + ], [ + 'field' => 'licenses_count', + 'searchable' => false, + 'sortable' => true, + 'title' => trans('general.licenses'), + 'visible' => true, + ], [ 'field' => 'actions', 'searchable' => false, From eb5d93b3c2bf22d11063830771675c4f081eb516 Mon Sep 17 00:00:00 2001 From: snipe Date: Wed, 28 Aug 2024 12:38:55 +0100 Subject: [PATCH 04/11] Added assets relationship Signed-off-by: snipe --- app/Models/Depreciation.php | 13 +++++++++++++ 1 file changed, 13 insertions(+) diff --git a/app/Models/Depreciation.php b/app/Models/Depreciation.php index 9faa1b86e..7aceddf7c 100755 --- a/app/Models/Depreciation.php +++ b/app/Models/Depreciation.php @@ -75,4 +75,17 @@ class Depreciation extends SnipeModel { return $this->hasMany(\App\Models\License::class, 'depreciation_id'); } + + /** + * Establishes the depreciation -> assets relationship + * + * @author A. Gianotto + * @since [v5.0] + * @return \Illuminate\Database\Eloquent\Relations\Relation + */ + public function assets() + { + return $this->hasManyThrough(\App\Models\Asset::class, \App\Models\AssetModel::class, 'depreciation_id', 'model_id'); + } + } From 486cd8c8c98d4fb83f28d7f8ab32894bde93f68f Mon Sep 17 00:00:00 2001 From: snipe Date: Wed, 28 Aug 2024 12:39:09 +0100 Subject: [PATCH 05/11] Nicer formatting for searchableAttributes Signed-off-by: snipe --- app/Models/AssetModel.php | 7 ++++++- 1 file changed, 6 insertions(+), 1 deletion(-) diff --git a/app/Models/AssetModel.php b/app/Models/AssetModel.php index 3c023507d..e9b859e12 100755 --- a/app/Models/AssetModel.php +++ b/app/Models/AssetModel.php @@ -79,7 +79,12 @@ class AssetModel extends SnipeModel * * @var array */ - protected $searchableAttributes = ['name', 'model_number', 'notes', 'eol']; + protected $searchableAttributes = [ + 'name', + 'model_number', + 'notes', + 'eol' + ]; /** * The relations and their attributes that should be included when searching the model. From 385c4f69f7225a76bbd548ee8f34aaaf0908a4f5 Mon Sep 17 00:00:00 2001 From: snipe Date: Wed, 28 Aug 2024 12:39:43 +0100 Subject: [PATCH 06/11] Added counts to depreciation transformer Signed-off-by: snipe --- app/Http/Transformers/DepreciationsTransformer.php | 3 +++ 1 file changed, 3 insertions(+) diff --git a/app/Http/Transformers/DepreciationsTransformer.php b/app/Http/Transformers/DepreciationsTransformer.php index 87e2ddaca..b3dc8c5aa 100644 --- a/app/Http/Transformers/DepreciationsTransformer.php +++ b/app/Http/Transformers/DepreciationsTransformer.php @@ -28,6 +28,9 @@ class DepreciationsTransformer 'name' => e($depreciation->name), 'months' => $depreciation->months.' '.trans('general.months'), 'depreciation_min' => $depreciation->depreciation_type === 'percent' ? $depreciation->depreciation_min.'%' : $depreciation->depreciation_min, + 'assets_count' => $depreciation->assets_count, + 'models_count' => $depreciation->models_count, + 'licenses_count' => $depreciation->licenses_count, 'created_at' => Helper::getFormattedDateObject($depreciation->created_at, 'datetime'), 'updated_at' => Helper::getFormattedDateObject($depreciation->updated_at, 'datetime') ]; From 63a05c89a72bb45d05c16350b9d710480fb1516f Mon Sep 17 00:00:00 2001 From: snipe Date: Wed, 28 Aug 2024 12:39:52 +0100 Subject: [PATCH 07/11] Added counts to show method Signed-off-by: snipe --- .../Controllers/DepreciationsController.php | 17 ++++++++++++----- 1 file changed, 12 insertions(+), 5 deletions(-) diff --git a/app/Http/Controllers/DepreciationsController.php b/app/Http/Controllers/DepreciationsController.php index c564cc98f..888f7a7e7 100755 --- a/app/Http/Controllers/DepreciationsController.php +++ b/app/Http/Controllers/DepreciationsController.php @@ -193,13 +193,20 @@ class DepreciationsController extends Controller */ public function show($id) : View | RedirectResponse { - if (is_null($depreciation = Depreciation::find($id))) { - // Redirect to the blogs management page - return redirect()->route('depreciations.index')->with('error', trans('admin/depreciations/message.does_not_exist')); - } + $depreciation = Depreciation::withCount('assets as assets_count') + ->withCount('models as models_count') + ->withCount('licenses as licenses_count') + ->find($id); $this->authorize('view', $depreciation); - return view('depreciations/view', compact('depreciation')); + if ($depreciation) { + return view('depreciations/view', compact('depreciation')); + + } + + return redirect()->route('depreciations.index')->with('error', trans('admin/depreciations/message.does_not_exist')); + + } } From 4839181beb926bbed2ef357078ba0892340384c2 Mon Sep 17 00:00:00 2001 From: snipe Date: Wed, 28 Aug 2024 12:40:01 +0100 Subject: [PATCH 08/11] Added counts to API Signed-off-by: snipe --- .../Controllers/Api/DepreciationsController.php | 17 +++++++++++++++-- 1 file changed, 15 insertions(+), 2 deletions(-) diff --git a/app/Http/Controllers/Api/DepreciationsController.php b/app/Http/Controllers/Api/DepreciationsController.php index 0209eae39..72e0f3a14 100644 --- a/app/Http/Controllers/Api/DepreciationsController.php +++ b/app/Http/Controllers/Api/DepreciationsController.php @@ -20,9 +20,22 @@ class DepreciationsController extends Controller public function index(Request $request) : JsonResponse | array { $this->authorize('view', Depreciation::class); - $allowed_columns = ['id','name','months','depreciation_min', 'depreciation_type','created_at']; + $allowed_columns = [ + 'id', + 'name', + 'months', + 'depreciation_min', + 'depreciation_type', + 'created_at', + 'assets_count', + 'models_count', + 'licenses_count', + ]; - $depreciations = Depreciation::select('id','name','months','depreciation_min','depreciation_type','user_id','created_at','updated_at'); + $depreciations = Depreciation::select('id','name','months','depreciation_min','depreciation_type','user_id','created_at','updated_at') + ->withCount('assets as assets_count') + ->withCount('models as models_count') + ->withCount('licenses as licenses_count'); if ($request->filled('search')) { $depreciations = $depreciations->TextSearch($request->input('search')); From c6ddc501c5b6f674c36363ccf301b584be817564 Mon Sep 17 00:00:00 2001 From: snipe Date: Wed, 28 Aug 2024 12:40:12 +0100 Subject: [PATCH 09/11] Filter by depreciation_id Signed-off-by: snipe --- app/Http/Controllers/Api/AssetModelsController.php | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/app/Http/Controllers/Api/AssetModelsController.php b/app/Http/Controllers/Api/AssetModelsController.php index 835f4d22e..9f7819342 100644 --- a/app/Http/Controllers/Api/AssetModelsController.php +++ b/app/Http/Controllers/Api/AssetModelsController.php @@ -78,6 +78,10 @@ class AssetModelsController extends Controller $assetmodels = $assetmodels->where('models.category_id', '=', $request->input('category_id')); } + if ($request->filled('depreciation_id')) { + $assetmodels = $assetmodels->where('models.depreciation_id', '=', $request->input('depreciation_id')); + } + if ($request->filled('search')) { $assetmodels->TextSearch($request->input('search')); } From 406ff6984b7b0c41aff78f2534e76edbbe30b4b5 Mon Sep 17 00:00:00 2001 From: snipe Date: Wed, 28 Aug 2024 12:42:23 +0100 Subject: [PATCH 10/11] Added click to select on models table Signed-off-by: snipe --- resources/views/depreciations/view.blade.php | 1 + 1 file changed, 1 insertion(+) diff --git a/resources/views/depreciations/view.blade.php b/resources/views/depreciations/view.blade.php index c836f8647..b49bf0b9e 100644 --- a/resources/views/depreciations/view.blade.php +++ b/resources/views/depreciations/view.blade.php @@ -163,6 +163,7 @@ data-sort-name="name" data-bulk-button-id="#AssetModelsBulkEditButton" data-bulk-form-id="#bulkForm" + data-click-to-select="true" class="table table-striped snipe-table" data-url="{{ route('api.models.index',['depreciation_id'=> $depreciation->id]) }}" data-export-options='{ From d635c86e0096825f46993310facfba8b05a47822 Mon Sep 17 00:00:00 2001 From: snipe Date: Wed, 28 Aug 2024 12:46:30 +0100 Subject: [PATCH 11/11] Added tests Signed-off-by: snipe --- .../Api/DepreciationsIndexTest.php | 17 ++++++++++++++ .../Ui/DepreciationsIndexTest.php | 23 +++++++++++++++++++ 2 files changed, 40 insertions(+) create mode 100644 tests/Feature/Depreciations/Api/DepreciationsIndexTest.php create mode 100644 tests/Feature/Depreciations/Ui/DepreciationsIndexTest.php diff --git a/tests/Feature/Depreciations/Api/DepreciationsIndexTest.php b/tests/Feature/Depreciations/Api/DepreciationsIndexTest.php new file mode 100644 index 000000000..29583001a --- /dev/null +++ b/tests/Feature/Depreciations/Api/DepreciationsIndexTest.php @@ -0,0 +1,17 @@ +actingAsForApi(User::factory()->create()) + ->getJson(route('api.departments.index')) + ->assertForbidden(); + } + +} diff --git a/tests/Feature/Depreciations/Ui/DepreciationsIndexTest.php b/tests/Feature/Depreciations/Ui/DepreciationsIndexTest.php new file mode 100644 index 000000000..90cb39b4e --- /dev/null +++ b/tests/Feature/Depreciations/Ui/DepreciationsIndexTest.php @@ -0,0 +1,23 @@ +actingAs(User::factory()->create()) + ->get(route('depreciations.index')) + ->assertForbidden(); + } + + public function testUserCanListDepreciations() + { + $this->actingAs(User::factory()->admin()->create()) + ->get(route('depreciations.index')) + ->assertOk(); + } +}