diff --git a/app/Http/Controllers/Api/LicenseSeatsController.php b/app/Http/Controllers/Api/LicenseSeatsController.php index 884c9c59c..a091741e8 100644 --- a/app/Http/Controllers/Api/LicenseSeatsController.php +++ b/app/Http/Controllers/Api/LicenseSeatsController.php @@ -42,6 +42,11 @@ class LicenseSeatsController extends Controller // Make sure the offset and limit are actually integers and do not exceed system limits $offset = ($request->input('offset') > $seats->count()) ? $seats->count() : abs($request->input('offset')); + + if ($offset >= $total ){ + $offset = 0; + } + $limit = app('api_limit_value'); $seats = $seats->skip($offset)->take($limit)->get(); diff --git a/app/Http/Controllers/Assets/AssetsController.php b/app/Http/Controllers/Assets/AssetsController.php index 76c12d3cf..74b3dffa1 100755 --- a/app/Http/Controllers/Assets/AssetsController.php +++ b/app/Http/Controllers/Assets/AssetsController.php @@ -774,7 +774,7 @@ class AssetsController extends Controller } /** - * Retore a deleted asset. + * Restore a deleted asset. * * @author [A. Gianotto] [] * @param int $assetId diff --git a/app/Models/Asset.php b/app/Models/Asset.php index 861269d5f..95e1c3a16 100644 --- a/app/Models/Asset.php +++ b/app/Models/Asset.php @@ -390,7 +390,7 @@ class Asset extends Depreciable */ public function depreciation() { - return $this->model->belongsTo(\App\Models\Depreciation::class, 'depreciation_id'); + return $this->hasOneThrough(\App\Models\Depreciation::class,\App\Models\AssetModel::class,'id','id','model_id','depreciation_id'); } diff --git a/resources/lang/en/admin/hardware/general.php b/resources/lang/en/admin/hardware/general.php index d413739e3..dd7d74e43 100644 --- a/resources/lang/en/admin/hardware/general.php +++ b/resources/lang/en/admin/hardware/general.php @@ -12,6 +12,7 @@ return [ 'clone' => 'Clone Asset', 'deployable' => 'Deployable', 'deleted' => 'This asset has been deleted.', + 'delete_confirm' => 'Are you sure you want to delete this asset?', 'edit' => 'Edit Asset', 'model_deleted' => 'This Assets model has been deleted. You must restore the model before you can restore the Asset.', 'model_invalid' => 'The Model of this Asset is invalid.', diff --git a/resources/lang/en/admin/models/message.php b/resources/lang/en/admin/models/message.php index 5f4733652..77c2d88b5 100644 --- a/resources/lang/en/admin/models/message.php +++ b/resources/lang/en/admin/models/message.php @@ -3,7 +3,7 @@ return array( 'does_not_exist' => 'Model does not exist.', - 'no_association' => 'NO MODEL ASSOCIATED.', + 'no_association' => 'WARNING! The asset model for this item is invalid or missing!', 'no_association_fix' => 'This will break things in weird and horrible ways. Edit this asset now to assign it a model.', 'assoc_users' => 'This model is currently associated with one or more assets and cannot be deleted. Please delete the assets, and then try deleting again. ', diff --git a/resources/lang/en/general.php b/resources/lang/en/general.php index 79cb87c47..483184572 100644 --- a/resources/lang/en/general.php +++ b/resources/lang/en/general.php @@ -264,7 +264,7 @@ return [ 'accept_eula' => 'Acceptance Agreement', 'supplier' => 'Supplier', 'suppliers' => 'Suppliers', - 'sure_to_delete' => 'Are you sure you wish to delete', + 'sure_to_delete' => 'Are you sure you wish to delete', 'submit' => 'Submit', 'target' => 'Target', 'time_and_date_display' => 'Time and Date Display', diff --git a/resources/views/custom_fields/fieldsets/view.blade.php b/resources/views/custom_fields/fieldsets/view.blade.php index c330522cc..003ee0cd8 100644 --- a/resources/views/custom_fields/fieldsets/view.blade.php +++ b/resources/views/custom_fields/fieldsets/view.blade.php @@ -51,7 +51,7 @@ @endcan - {{$field->pivot->order}} + {{$field->pivot->order + 1}} {{$field->name}} {{$field->format}} {{$field->element}} diff --git a/resources/views/hardware/view.blade.php b/resources/views/hardware/view.blade.php index dddccf1e3..6c1aef99e 100755 --- a/resources/views/hardware/view.blade.php +++ b/resources/views/hardware/view.blade.php @@ -6,67 +6,6 @@ @parent @stop -{{-- Right header --}} -@section('header_right') - - - @can('manage', \App\Models\Asset::class) - @if ($asset->deleted_at=='') - - @endif - @endcan -@stop - {{-- Page content --}} @section('content') @@ -75,8 +14,7 @@ @if (!$asset->model)
-

{{ trans('admin/models/message.no_association') }}

-

{{ trans('admin/models/message.no_association_fix') }}

+

{{ trans('admin/models/message.no_association') }} {{ trans('admin/models/message.no_association_fix') }}

@endif @@ -183,7 +121,7 @@ @@ -626,7 +564,7 @@ {{ $asset->warranty_months }} {{ trans('admin/hardware/form.months') }} - @if (($asset->model->manufacturer) && ($asset->model->manufacturer->warranty_lookup_url!='')) + @if (($asset->model) && ($asset->model->manufacturer) && ($asset->model->manufacturer->warranty_lookup_url!='')) @@ -885,17 +823,73 @@
@if (($asset->image) || (($asset->model) && ($asset->model->image!=''))) - - + @else + @endif + + + @if (($asset->assetstatus) && ($asset->assetstatus->deployable=='1')) + @if (($asset->assigned_to != '') && ($asset->deleted_at=='')) + @can('checkin', \App\Models\Asset::class) + + @endcan + @elseif (($asset->assigned_to == '') && ($asset->deleted_at=='')) + @can('checkout', \App\Models\Asset::class) + + @endcan + @endif + @endif + + + @can('update', $asset) + + @endcan + + @can('create', $asset) + + @endcan + + @can('audit', \App\Models\Asset::class) + + @endcan + + @can('delete', $asset) + @if ($asset->deleted_at=='') +
+ + {{ trans('general.delete') }} +
+ @endif + @endcan + @if ($asset->deleted_at!='') -
+
@csrf @@ -908,11 +902,13 @@ @endif @if (($asset->assignedTo) && ($asset->deleted_at=='')) -

{{ trans('admin/hardware/form.checkedout_to') }}

+
+

{{ trans('admin/hardware/form.checkedout_to') }}

@if($asset->checkedOutToUser()) {{ $asset->assignedTo->present()->fullName() }} @endif +

{!! $asset->assignedTo->present()->glyph() . ' ' .$asset->assignedTo->present()->nameUrl() !!}

@@ -959,6 +955,7 @@ @endif +
@endif
@@ -1305,7 +1302,7 @@
- @if ($asset->model->uploads->count() > 0) + @if (($asset->model) && ($asset->model->uploads->count() > 0)) + + $('#dataConfirmModal').on('show.bs.modal', function (event) { + var content = $(event.relatedTarget).data('content'); + var title = $(event.relatedTarget).data('title'); + $(this).find(".modal-body").text(content); + $(this).find(".modal-header").text(title); + }); + + @include ('partials.bootstrap-table') @stop