lunax/snipe_it
1
0
Fork 0
Code Issues Pull requests Projects Releases Wiki Activity Actions

Remove incomplete tests

Browse source
This commit is contained in:
Marcus Moore 2023-06-26 14:00:53 -07:00
parent 3cb0920411
commit 7cb22d3d49
No known key found for this signature in database
3 changed files with 0 additions and 148 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

64
tests/Feature/Api/Departments/DepartmentsIndexTest.php
View file

@ -1,64 +0,0 @@
<?php
namespace Tests\Feature\Api\Departments;
use App\Models\Company;
use App\Models\Department;
use App\Models\User;
use Tests\Support\InteractsWithSettings;
use Tests\TestCase;
class DepartmentsIndexTest extends TestCase
{
use InteractsWithSettings;
public function testDepartmentsIndexAdheresToCompanyScoping()
{
$this->markTestIncomplete(
'Waiting for removal of Company::scopeCompanyables in DepartmentsController@index'
);
[$companyA, $companyB] = Company::factory()->count(2)->create();
$departmentA = Department::factory()->for($companyA)->create();
$departmentB = Department::factory()->for($companyB)->create();
$superUser = $companyA->users()->save(User::factory()->superuser()->make());
$userInCompanyA = $companyA->users()->save(User::factory()->viewDepartments()->make());
$userInCompanyB = $companyB->users()->save(User::factory()->viewDepartments()->make());
$this->settings->disableMultipleFullCompanySupport();
$this->actingAsForApi($superUser)
->getJson(route('api.departments.index'))
->assertResponseContainsInRows($departmentA)
->assertResponseContainsInRows($departmentB);
$this->actingAsForApi($userInCompanyA)
->getJson(route('api.departments.index'))
->assertResponseContainsInRows($departmentA)
->assertResponseContainsInRows($departmentB);
$this->actingAsForApi($userInCompanyB)
->getJson(route('api.departments.index'))
->assertResponseContainsInRows($departmentA)
->assertResponseContainsInRows($departmentB);
$this->settings->enableMultipleFullCompanySupport();
$this->actingAsForApi($superUser)
->getJson(route('api.departments.index'))
->assertResponseContainsInRows($departmentA)
->assertResponseContainsInRows($departmentB);
$this->actingAsForApi($userInCompanyA)
->getJson(route('api.departments.index'))
->assertResponseContainsInRows($departmentA)
->assertResponseDoesNotContainInRows($departmentB);
$this->actingAsForApi($userInCompanyB)
->getJson(route('api.departments.index'))
->assertResponseDoesNotContainInRows($departmentA)
->assertResponseContainsInRows($departmentB);
}
}

63
tests/Feature/Api/Users/UsersIndexTest.php
View file

@ -1,63 +0,0 @@
<?php
namespace Tests\Feature\Api\Users;
use App\Models\Company;
use App\Models\User;
use Tests\Support\InteractsWithSettings;
use Tests\TestCase;
class UsersIndexTest extends TestCase
{
use InteractsWithSettings;
public function testUsersIndexAdheresToCompanyScoping()
{
$this->markTestIncomplete(
'Waiting for removal of Company::scopeCompanyables in UsersController@index'
);
[$companyA, $companyB] = Company::factory()->count(2)->create();
$userA = User::factory()->for($companyA)->create();
$userB = User::factory()->for($companyB)->create();
$superUser = $companyA->users()->save(User::factory()->superuser()->make());
$userInCompanyA = $companyA->users()->save(User::factory()->viewUsers()->make());
$userInCompanyB = $companyB->users()->save(User::factory()->viewUsers()->make());
$this->settings->disableMultipleFullCompanySupport();
$this->actingAsForApi($superUser)
->getJson(route('api.users.index'))
->assertResponseContainsInRows($userA, 'first_name')
->assertResponseContainsInRows($userB, 'first_name');
$this->actingAsForApi($userInCompanyA)
->getJson(route('api.users.index'))
->assertResponseContainsInRows($userA, 'first_name')
->assertResponseContainsInRows($userB, 'first_name');
$this->actingAsForApi($userInCompanyB)
->getJson(route('api.users.index'))
->assertResponseContainsInRows($userA, 'first_name')
->assertResponseContainsInRows($userB, 'first_name');
$this->settings->enableMultipleFullCompanySupport();
$this->actingAsForApi($superUser)
->getJson(route('api.users.index'))
->assertResponseContainsInRows($userA, 'first_name')
->assertResponseContainsInRows($userB, 'first_name');
$this->actingAsForApi($userInCompanyA)
->getJson(route('api.users.index'))
->assertResponseContainsInRows($userA, 'first_name')
->assertResponseDoesNotContainInRows($userB, 'first_name');
$this->actingAsForApi($userInCompanyB)
->getJson(route('api.users.index'))
->assertResponseDoesNotContainInRows($userA, 'first_name')
->assertResponseContainsInRows($userB, 'first_name');
}
}

21
tests/Feature/DashboardTest.php
View file

@ -2,7 +2,6 @@
namespace Tests\Feature; namespace Tests\Feature;
use App\Models\Company;
use App\Models\User; use App\Models\User;
use Tests\Support\InteractsWithSettings; use Tests\Support\InteractsWithSettings;
use Tests\TestCase; use Tests\TestCase;
@ -17,24 +16,4 @@ class DashboardTest extends TestCase
->get(route('home')) ->get(route('home'))
->assertRedirect(route('view-assets')); ->assertRedirect(route('view-assets'));
} }
public function testUserCountIsScopedByCompany()
{
$this->markTestIncomplete(
'Waiting for removal of Company::scopeCompanyables in DashboardController@index'
);
$this->settings->enableMultipleFullCompanySupport();
$companyA = Company::factory()->has(User::factory()->count(1))->create();
Company::factory()->has(User::factory()->count(3))->create();
$adminForCompanyA = $companyA->users()->save(User::factory()->admin()->make());
$this->actingAs($adminForCompanyA)
->get(route('home'))
->assertOk()
->assertViewIs('dashboard')
->assertViewHas('counts', fn($counts) => $counts['user'] === $companyA->users->count());
}
} }