From 538757317b8c532623b7378a3ebdf71925220ed2 Mon Sep 17 00:00:00 2001 From: snipe Date: Wed, 22 Nov 2017 06:20:28 -0800 Subject: [PATCH 01/16] =?UTF-8?q?Fixed=20#4411=20-=20broken=20activity=20r?= =?UTF-8?q?eport=20if=20purge=20didn=E2=80=99t=20remove=20relationship=20e?= =?UTF-8?q?ntries?= MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit --- resources/views/partials/bootstrap-table.blade.php | 8 ++++++++ 1 file changed, 8 insertions(+) diff --git a/resources/views/partials/bootstrap-table.blade.php b/resources/views/partials/bootstrap-table.blade.php index 8b32bd5ad..8a51b1e71 100644 --- a/resources/views/partials/bootstrap-table.blade.php +++ b/resources/views/partials/bootstrap-table.blade.php @@ -276,6 +276,14 @@ } + // This just prints out the item type in the activity report + function itemTypeFormatter(value, row) { + + if ((row) && (row.item) && (row.item.type)) { + return row.item.type; + } + } + function genericCheckinCheckoutFormatter(destination) { return function (value,row) { From 9430c4bf43bfe2a7d8d81cb00ede81652b6f7655 Mon Sep 17 00:00:00 2001 From: snipe Date: Wed, 22 Nov 2017 06:20:51 -0800 Subject: [PATCH 02/16] Added sanity checks in BS tables formatter --- resources/views/partials/bootstrap-table.blade.php | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/resources/views/partials/bootstrap-table.blade.php b/resources/views/partials/bootstrap-table.blade.php index 8a51b1e71..adb3c9b55 100644 --- a/resources/views/partials/bootstrap-table.blade.php +++ b/resources/views/partials/bootstrap-table.blade.php @@ -448,7 +448,7 @@ } function assetCompanyObjFilterFormatter(value, row) { - if (row.company) { + if ((row) && (row.company)) { return ' ' + row.company.name + ''; } } @@ -463,7 +463,7 @@ function employeeNumFormatter(value, row) { - if ((row.assigned_to) && ((row.assigned_to.employee_number))) { + if ((row) && (row.assigned_to) && ((row.assigned_to.employee_number))) { return ' ' + row.assigned_to.employee_number + ''; } } From 964c594c4cb7f90fc8a86dfa106043210e3168e3 Mon Sep 17 00:00:00 2001 From: snipe Date: Wed, 22 Nov 2017 06:21:06 -0800 Subject: [PATCH 03/16] Added ItemFormatter for acrtivity report --- resources/views/reports/activity.blade.php | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/resources/views/reports/activity.blade.php b/resources/views/reports/activity.blade.php index 6dc6afb87..755266d01 100644 --- a/resources/views/reports/activity.blade.php +++ b/resources/views/reports/activity.blade.php @@ -25,10 +25,10 @@ - {{ trans('general.date') }} + {{ trans('general.date') }} {{ trans('general.admin') }} {{ trans('general.action') }} - {{ trans('general.type') }} + {{ trans('general.type') }} {{ trans('general.item') }} To {{ trans('general.notes') }} From 3aaaea37e47c7dfb147a818b57c0460b021edd8f Mon Sep 17 00:00:00 2001 From: snipe Date: Wed, 22 Nov 2017 06:21:56 -0800 Subject: [PATCH 04/16] Added - sync locations artican call after seed --- database/seeds/DatabaseSeeder.php | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/database/seeds/DatabaseSeeder.php b/database/seeds/DatabaseSeeder.php index 00c493faa..b424dbc9e 100644 --- a/database/seeds/DatabaseSeeder.php +++ b/database/seeds/DatabaseSeeder.php @@ -33,6 +33,10 @@ class DatabaseSeeder extends Seeder $this->call(ActionlogSeeder::class); $this->call(CustomFieldSeeder::class); + Artisan::call('snipeit:sync-asset-locations', ['--output' => 'all']); + $output = Artisan::output(); + \Log::info($output); + Model::reguard(); } } From 980be651938e35ed5e3286d04a50872e9a63ec57 Mon Sep 17 00:00:00 2001 From: snipe Date: Wed, 22 Nov 2017 07:07:18 -0800 Subject: [PATCH 05/16] Added ability to turn items on/off in checkout-selector --- resources/views/hardware/checkout.blade.php | 2 +- resources/views/hardware/edit.blade.php | 9 +++++---- resources/views/licenses/checkout.blade.php | 8 +++----- .../views/partials/forms/checkout-selector.blade.php | 6 ++++++ .../views/partials/forms/edit/asset-select.blade.php | 2 +- 5 files changed, 16 insertions(+), 11 deletions(-) diff --git a/resources/views/hardware/checkout.blade.php b/resources/views/hardware/checkout.blade.php index 5a8a7a574..2ec61fc42 100755 --- a/resources/views/hardware/checkout.blade.php +++ b/resources/views/hardware/checkout.blade.php @@ -44,7 +44,7 @@ {!! $errors->first('name', ' :message') !!} - @include ('partials.forms.checkout-selector') + @include ('partials.forms.checkout-selector', ['user_select' => 'true','asset_select' => 'true', 'location_select' => 'true']) @include ('partials.forms.edit.user-select', ['translated_name' => trans('general.user'), 'fieldname' => 'assigned_user', 'required'=>'true']) @if ($asset->requireAcceptance()) diff --git a/resources/views/hardware/edit.blade.php b/resources/views/hardware/edit.blade.php index 8a2d7d89e..70a96386e 100755 --- a/resources/views/hardware/edit.blade.php +++ b/resources/views/hardware/edit.blade.php @@ -47,13 +47,13 @@ @include ('partials.forms.edit.status') @if (!$item->id) - @include ('partials.forms.checkout-selector', ['style' => 'display:none;']) + @include ('partials.forms.checkout-selector', ['user_select' => 'true','asset_select' => 'true', 'location_select' => 'true', 'style' => 'display:none;']) - @include ('partials.forms.edit.user-select', ['translated_name' => trans('admin/hardware/form.checkout_to'), 'fieldname' => 'assigned_user', 'style' => 'display:none;']) + @include ('partials.forms.edit.user-select', ['translated_name' => trans('admin/hardware/form.checkout_to'), 'fieldname' => 'assigned_user', 'style' => 'display:none;', 'required' => 'false']) - @include ('partials.forms.edit.asset-select', ['translated_name' => trans('admin/hardware/form.checkout_to'), 'fieldname' => 'assigned_asset', 'style' => 'display:none;']) + @include ('partials.forms.edit.asset-select', ['translated_name' => trans('admin/hardware/form.checkout_to'), 'fieldname' => 'assigned_asset', 'style' => 'display:none;', 'required' => 'false']) - @include ('partials.forms.edit.location-select', ['translated_name' => trans('admin/hardware/form.checkout_to'), 'fieldname' => 'assigned_location', 'style' => 'display:none;']) + @include ('partials.forms.edit.location-select', ['translated_name' => trans('admin/hardware/form.checkout_to'), 'fieldname' => 'assigned_location', 'style' => 'display:none;', 'required' => 'false']) @endif @include ('partials.forms.edit.serial', ['translated_serial' => trans('admin/hardware/form.serial')]) @@ -146,6 +146,7 @@ if (data == true) { $("#assignto_selector").show(); + $("#assigned_user").show(); $("#selected_status_status").removeClass('text-danger'); $("#selected_status_status").addClass('text-success'); diff --git a/resources/views/licenses/checkout.blade.php b/resources/views/licenses/checkout.blade.php index 47ce4a7c0..7e348e9e0 100755 --- a/resources/views/licenses/checkout.blade.php +++ b/resources/views/licenses/checkout.blade.php @@ -41,13 +41,11 @@ - @include ('partials.forms.edit.asset-select', ['translated_name' => trans('admin/licenses/form.asset'), 'fieldname' => 'asset_id']) + @include ('partials.forms.checkout-selector', ['user_select' => 'true','asset_select' => 'true', 'location_select' => 'false']) - @include ('partials.forms.edit.user-select', ['translated_name' => trans('admin/hardware/form.checkout_to'), 'fieldname' => 'assigned_to']) + @include ('partials.forms.edit.user-select', ['translated_name' => trans('general.user'), 'fieldname' => 'assigned_to', 'required'=>'true']) -

- {{ trans('admin/licenses/form.checkout_help') }} -

+ @include ('partials.forms.edit.asset-select', ['translated_name' => trans('admin/licenses/form.asset'), 'fieldname' => 'asset_id', 'style' => 'display:none;']) diff --git a/resources/views/partials/forms/checkout-selector.blade.php b/resources/views/partials/forms/checkout-selector.blade.php index b51a5d09b..600470b6f 100644 --- a/resources/views/partials/forms/checkout-selector.blade.php +++ b/resources/views/partials/forms/checkout-selector.blade.php @@ -2,15 +2,21 @@ {{ Form::label('name', trans('admin/hardware/form.checkout_to'), array('class' => 'col-md-3 control-label')) }}
+ @if ((isset($user_select)) && ($user_select!='false')) + @endif + @if ((isset($asset_select)) && ($asset_select!='false')) + @endif + @if ((isset($location_select)) && ($location_select!='false')) + @endif
diff --git a/resources/views/partials/forms/edit/asset-select.blade.php b/resources/views/partials/forms/edit/asset-select.blade.php index acaff7a34..d554e2925 100644 --- a/resources/views/partials/forms/edit/asset-select.blade.php +++ b/resources/views/partials/forms/edit/asset-select.blade.php @@ -1,5 +1,5 @@ -
+
{{ Form::label($fieldname, $translated_name, array('class' => 'col-md-3 control-label')) }}
@if ($supplier_id = Input::old($fieldname, (isset($item)) ? $item->{$fieldname} : ''))