From 8e358faebcda3071a2edacefb5bb7140bd5f0ba5 Mon Sep 17 00:00:00 2001 From: snipe Date: Tue, 12 Feb 2019 22:15:32 -0800 Subject: [PATCH] Fixed #6113 - use $asset->fill vs filled() to allow blanking values via API --- app/Http/Controllers/Api/AssetsController.php | 35 +++---------------- app/Http/Kernel.php | 2 +- 2 files changed, 5 insertions(+), 32 deletions(-) diff --git a/app/Http/Controllers/Api/AssetsController.php b/app/Http/Controllers/Api/AssetsController.php index 158bdc855..05c02514e 100644 --- a/app/Http/Controllers/Api/AssetsController.php +++ b/app/Http/Controllers/Api/AssetsController.php @@ -476,39 +476,12 @@ class AssetsController extends Controller { $this->authorize('update', Asset::class); + $asset->fill($request->all()); + + if ($asset = Asset::find($id)) { ($request->filled('model_id')) ? - $asset->model()->associate(AssetModel::find($request->get('model_id'))) : ''; - ($request->filled('name')) ? - $asset->name = $request->get('name') : ''; - ($request->filled('serial')) ? - $asset->serial = $request->get('serial') : ''; - ($request->filled('model_id')) ? - $asset->model_id = $request->get('model_id') : ''; - ($request->filled('order_number')) ? - $asset->order_number = $request->get('order_number') : ''; - ($request->filled('notes')) ? - $asset->notes = $request->get('notes') : ''; - ($request->filled('asset_tag')) ? - $asset->asset_tag = $request->get('asset_tag') : ''; - ($request->filled('archived')) ? - $asset->archived = $request->get('archived') : ''; - ($request->filled('status_id')) ? - $asset->status_id = $request->get('status_id') : ''; - ($request->filled('warranty_months')) ? - $asset->warranty_months = $request->get('warranty_months') : ''; - ($request->filled('purchase_cost')) ? - $asset->purchase_cost = Helper::ParseFloat($request->get('purchase_cost')) : ''; - ($request->filled('purchase_date')) ? - $asset->purchase_date = $request->get('purchase_date') : ''; - ($request->filled('assigned_to')) ? - $asset->assigned_to = $request->get('assigned_to') : ''; - ($request->filled('supplier_id')) ? - $asset->supplier_id = $request->get('supplier_id') : ''; - ($request->filled('requestable')) ? - $asset->requestable = $request->get('requestable') : ''; - ($request->filled('rtd_location_id')) ? - $asset->rtd_location_id = $request->get('rtd_location_id') : ''; + $asset->model()->associate(AssetModel::find($request->get('model_id'))) : null; ($request->filled('rtd_location_id')) ? $asset->location_id = $request->get('rtd_location_id') : ''; ($request->filled('company_id')) ? diff --git a/app/Http/Kernel.php b/app/Http/Kernel.php index 3bee95097..4b46e1dd9 100644 --- a/app/Http/Kernel.php +++ b/app/Http/Kernel.php @@ -25,7 +25,7 @@ class Kernel extends HttpKernel \Fideloper\Proxy\TrustProxies::class, \App\Http\Middleware\CheckForSetup::class, \App\Http\Middleware\CheckForDebug::class, - // \Illuminate\Foundation\Http\Middleware\ConvertEmptyStringsToNull::class, + \Illuminate\Foundation\Http\Middleware\ConvertEmptyStringsToNull::class, ]; /**