From e9f3d622f567044ba99e19f32c3b37a749e03ae5 Mon Sep 17 00:00:00 2001 From: snipe Date: Tue, 27 Sep 2016 07:19:52 -0700 Subject: [PATCH 01/10] Add company name to custom asset report --- app/Http/Controllers/ReportsController.php | 27 ++++++++++++---------- resources/views/reports/custom.blade.php | 7 ++++++ 2 files changed, 22 insertions(+), 12 deletions(-) diff --git a/app/Http/Controllers/ReportsController.php b/app/Http/Controllers/ReportsController.php index 3b9104afc..71248820e 100644 --- a/app/Http/Controllers/ReportsController.php +++ b/app/Http/Controllers/ReportsController.php @@ -381,24 +381,25 @@ class ReportsController extends Controller } /** - * Exports the custom report to CSV - * - * @author [A. Gianotto] [] - * @see ReportsController::getCustomReport() method that generates form view - * @since [v1.0] - * @return \Illuminate\Http\Response - */ + * Exports the custom report to CSV + * + * @author [A. Gianotto] [] + * @see ReportsController::getCustomReport() method that generates form view + * @since [v1.0] + * @return \Illuminate\Http\Response + */ public function postCustom() { - $assets = Asset::orderBy('created_at', 'DESC')->get(); + $assets = Asset::orderBy('created_at', 'DESC')->with('company','assigneduser', 'assetloc','defaultLoc','assigneduser.userloc','model','supplier','assetstatus','model.manufacturer')->get(); $customfields = CustomField::get(); $rows = [ ]; $header = [ ]; - if (e(Input::get('company_name')) == '1') { + if (e(Input::get('company')) == '1') { $header[] = 'Company Name'; } + if (e(Input::get('asset_name')) == '1') { $header[] = 'Asset Name'; } @@ -465,9 +466,10 @@ class ReportsController extends Controller foreach ($assets as $asset) { $row = [ ]; - if (e(Input::get('company_name')) == '1') { + if (e(Input::get('company')) == '1') { $row[] = is_null($asset->company) ? '' : e($asset->company->name); } + if (e(Input::get('asset_name')) == '1') { $row[] = '"' .e($asset->name) . '"'; } @@ -594,14 +596,15 @@ class ReportsController extends Controller $csv = implode($rows, "\n"); $response = Response::make($csv, 200); $response->header('Content-Type', 'text/csv'); - $response->header('Content-disposition', 'attachment;filename=report.csv'); + $response->header('Content-disposition', 'attachment;filename='.date('Y-m-d-His').'-custom-asset-report.csv'); return $response; } else { return redirect()->to("reports/custom") - ->with('error', trans('admin/reports/message.error')); + ->with('error', trans('admin/reports/message.error')); } } + /** * getImprovementsReport diff --git a/resources/views/reports/custom.blade.php b/resources/views/reports/custom.blade.php index 6a5f48938..63b61fbbe 100644 --- a/resources/views/reports/custom.blade.php +++ b/resources/views/reports/custom.blade.php @@ -34,6 +34,13 @@
+
+ +
+
@@ -130,6 +86,7 @@ + @stop From 67f199b09da963c5d9b5c83eeed81feb9582e4d9 Mon Sep 17 00:00:00 2001 From: snipe Date: Tue, 27 Sep 2016 15:09:47 -0700 Subject: [PATCH 08/10] Added customfields to asset CSV export --- app/Http/Controllers/ReportsController.php | 92 ++++++++++++---------- 1 file changed, 51 insertions(+), 41 deletions(-) diff --git a/app/Http/Controllers/ReportsController.php b/app/Http/Controllers/ReportsController.php index d75784a81..f39a8a66c 100644 --- a/app/Http/Controllers/ReportsController.php +++ b/app/Http/Controllers/ReportsController.php @@ -115,53 +115,63 @@ class ReportsController extends Controller \Debugbar::disable(); + $customfields = CustomField::get(); + $response = new StreamedResponse(function(){ // Open output stream $handle = fopen('php://output', 'w'); Asset::with('assigneduser', 'assetloc','defaultLoc','assigneduser.userloc','model','supplier','assetstatus','model.manufacturer')->orderBy('created_at', 'DESC')->chunk(500, function($assets) use($handle) { - fputcsv($handle, [ - trans('general.company'), - trans('admin/hardware/table.asset_tag'), - trans('admin/hardware/form.manufacturer'), - trans('admin/hardware/form.model'), - trans('general.model_no'), - trans('general.name'), - trans('admin/hardware/table.serial'), - trans('general.status'), - trans('admin/hardware/table.purchase_date'), - trans('admin/hardware/table.purchase_cost'), - trans('admin/hardware/form.order'), - trans('admin/hardware/form.supplier'), - trans('admin/hardware/table.checkoutto'), - trans('admin/hardware/table.checkout_date'), - trans('admin/hardware/table.location'), - trans('general.notes'), - ]); + $headers=[ + trans('general.company'), + trans('admin/hardware/table.asset_tag'), + trans('admin/hardware/form.manufacturer'), + trans('admin/hardware/form.model'), + trans('general.model_no'), + trans('general.name'), + trans('admin/hardware/table.serial'), + trans('general.status'), + trans('admin/hardware/table.purchase_date'), + trans('admin/hardware/table.purchase_cost'), + trans('admin/hardware/form.order'), + trans('admin/hardware/form.supplier'), + trans('admin/hardware/table.checkoutto'), + trans('admin/hardware/table.checkout_date'), + trans('admin/hardware/table.location'), + trans('general.notes'), + ]; + foreach($customfields as $field) { + $headers[]=$field->name; + } + fputcsv($handle, $headers); - foreach ($assets as $asset) { - // Add a new row with data - fputcsv($handle, [ - ($asset->company) ? $asset->company->name : '', - $asset->asset_tag, - ($asset->model->manufacturer) ? $asset->model->manufacturer->name : '', - ($asset->model) ? $asset->model->name : '', - ($asset->model->modelno) ? $asset->model->modelno : '', - ($asset->name) ? $asset->name : '', - ($asset->serial) ? $asset->serial : '', - ($asset->assetstatus) ? e($asset->assetstatus->name) : '', - ($asset->purchase_date) ? e($asset->purchase_date) : '', - ($asset->purchase_cost > 0) ? Helper::formatCurrencyOutput($asset->purchase_cost) : '', - ($asset->order_number) ? e($asset->order_number) : '', - ($asset->supplier) ? e($asset->supplier->name) : '', - ($asset->assigneduser) ? e($asset->assigneduser->fullName()) : '', - ($asset->last_checkout!='') ? e($asset->last_checkout) : '', - ($asset->assigneduser && $asset->assigneduser->userloc!='') ? - e($asset->assigneduser->userloc->name) : ( ($asset->defaultLoc!='') ? e($asset->defaultLoc->name) : ''), - ($asset->notes) ? e($asset->notes) : '', - ]); - } - }); + foreach ($assets as $asset) { + // Add a new row with data + $values=[ + ($asset->company) ? $asset->company->name : '', + $asset->asset_tag, + ($asset->model->manufacturer) ? $asset->model->manufacturer->name : '', + ($asset->model) ? $asset->model->name : '', + ($asset->model->modelno) ? $asset->model->modelno : '', + ($asset->name) ? $asset->name : '', + ($asset->serial) ? $asset->serial : '', + ($asset->assetstatus) ? e($asset->assetstatus->name) : '', + ($asset->purchase_date) ? e($asset->purchase_date) : '', + ($asset->purchase_cost > 0) ? Helper::formatCurrencyOutput($asset->purchase_cost) : '', + ($asset->order_number) ? e($asset->order_number) : '', + ($asset->supplier) ? e($asset->supplier->name) : '', + ($asset->assigneduser) ? e($asset->assigneduser->fullName()) : '', + ($asset->last_checkout!='') ? e($asset->last_checkout) : '', + ($asset->assigneduser && $asset->assigneduser->userloc!='') ? + e($asset->assigneduser->userloc->name) : ( ($asset->defaultLoc!='') ? e($asset->defaultLoc->name) : ''), + ($asset->notes) ? e($asset->notes) : '', + ]; + foreach($customfields as $field) { + $values[]=$asset->{$field->db_column_name()}; + } + fputcsv($handle, $values); + } + }); // Close the output stream fclose($handle); From ee2522571cffa62960e7252fd092c42c7e45f29c Mon Sep 17 00:00:00 2001 From: snipe Date: Tue, 27 Sep 2016 19:07:30 -0700 Subject: [PATCH 09/10] Fixes #2673 --- app/Http/Controllers/AccessoriesController.php | 4 ++-- app/Http/Controllers/AssetMaintenancesController.php | 4 ++-- app/Http/Controllers/AssetsController.php | 6 +++--- app/Http/Controllers/ComponentsController.php | 4 ++-- app/Http/Controllers/ConsumablesController.php | 6 +++--- app/Http/Controllers/LicensesController.php | 11 +++-------- 6 files changed, 15 insertions(+), 20 deletions(-) diff --git a/app/Http/Controllers/AccessoriesController.php b/app/Http/Controllers/AccessoriesController.php index 7f8c6debe..ea20762fc 100755 --- a/app/Http/Controllers/AccessoriesController.php +++ b/app/Http/Controllers/AccessoriesController.php @@ -92,7 +92,7 @@ class AccessoriesController extends Controller if (e(Input::get('purchase_cost')) == '0.00') { $accessory->purchase_cost = null; } else { - $accessory->purchase_cost = e(Input::get('purchase_cost')); + $accessory->purchase_cost = Helper::ParseFloat(e(Input::get('purchase_cost')))p; } $accessory->qty = e(Input::get('qty')); @@ -126,7 +126,7 @@ class AccessoriesController extends Controller } return View::make('accessories/edit', compact('accessory')) - ->with('category_list', Helper::categoryList('accessory')) + ->with('category_list', erper::categoryList('accessory')) ->with('company_list', Helper::companyList()) ->with('location_list', Helper::locationsList()) ->with('manufacturer_list', Helper::manufacturerList()); diff --git a/app/Http/Controllers/AssetMaintenancesController.php b/app/Http/Controllers/AssetMaintenancesController.php index b7bdb81bb..ea2a1bcce 100644 --- a/app/Http/Controllers/AssetMaintenancesController.php +++ b/app/Http/Controllers/AssetMaintenancesController.php @@ -215,7 +215,7 @@ class AssetMaintenancesController extends Controller if (e(Input::get('cost')) == '') { $assetMaintenance->cost = ''; } else { - $assetMaintenance->cost = e(Input::get('cost')); + $assetMaintenance->cost = Helper::ParseFloat(e(Input::get('cost'))); } if (e(Input::get('notes')) == '') { @@ -363,7 +363,7 @@ class AssetMaintenancesController extends Controller if (e(Input::get('cost')) == '') { $assetMaintenance->cost = ''; } else { - $assetMaintenance->cost = e(Input::get('cost')); + $assetMaintenance->cost = Helper::ParseFloat(e(Input::get('cost'))); } if (e(Input::get('notes')) == '') { diff --git a/app/Http/Controllers/AssetsController.php b/app/Http/Controllers/AssetsController.php index c89d9f3d1..8e9c3ba26 100755 --- a/app/Http/Controllers/AssetsController.php +++ b/app/Http/Controllers/AssetsController.php @@ -178,7 +178,7 @@ class AssetsController extends Controller if (e(Input::get('purchase_cost')) == '') { $asset->purchase_cost = null; } else { - $asset->purchase_cost = (e(Input::get('purchase_cost'))); + $asset->purchase_cost = Helper::ParseFloat(e(Input::get('purchase_cost'))); } if (e(Input::get('purchase_date')) == '') { @@ -354,7 +354,7 @@ class AssetsController extends Controller } if ($request->has('purchase_cost')) { - $asset->purchase_cost = e(Helper::formatCurrencyOutput($request->input('purchase_cost'))); + $asset->purchase_cost = Helper::ParseFloat(e($request->input('purchase_cost'))); } else { $asset->purchase_cost = null; } @@ -1491,7 +1491,7 @@ class AssetsController extends Controller } if (Input::has('purchase_cost')) { - $update_array['purchase_cost'] = e(Input::get('purchase_cost')); + $update_array['purchase_cost'] = Helper::ParseFloat(e(Input::get('purchase_cost'))); } if (Input::has('supplier_id')) { diff --git a/app/Http/Controllers/ComponentsController.php b/app/Http/Controllers/ComponentsController.php index 5debde18f..9de9b6733 100644 --- a/app/Http/Controllers/ComponentsController.php +++ b/app/Http/Controllers/ComponentsController.php @@ -99,7 +99,7 @@ class ComponentsController extends Controller if (e(Input::get('purchase_cost')) == '0.00') { $component->purchase_cost = null; } else { - $component->purchase_cost = e(Input::get('purchase_cost')); + $component->purchase_cost = Helper::ParseFloat(e(Input::get('purchase_cost'))); } $component->total_qty = e(Input::get('total_qty')); @@ -183,7 +183,7 @@ class ComponentsController extends Controller if (e(Input::get('purchase_cost')) == '0.00') { $component->purchase_cost = null; } else { - $component->purchase_cost = e(Input::get('purchase_cost')); + $component->purchase_cost = Helper::ParseFloat(e(Input::get('purchase_cost'))); } $component->total_qty = e(Input::get('total_qty')); diff --git a/app/Http/Controllers/ConsumablesController.php b/app/Http/Controllers/ConsumablesController.php index 821c388fd..3743ff0bc 100644 --- a/app/Http/Controllers/ConsumablesController.php +++ b/app/Http/Controllers/ConsumablesController.php @@ -97,7 +97,7 @@ class ConsumablesController extends Controller if (e(Input::get('purchase_cost')) == '0.00') { $consumable->purchase_cost = null; } else { - $consumable->purchase_cost = e(Input::get('purchase_cost')); + $consumable->purchase_cost = Helper::ParseFloat(e(Input::get('purchase_cost'))); } $consumable->qty = e(Input::get('qty')); @@ -182,10 +182,10 @@ class ConsumablesController extends Controller if (e(Input::get('purchase_cost')) == '0.00') { $consumable->purchase_cost = null; } else { - $consumable->purchase_cost = e(Input::get('purchase_cost')); + $consumable->purchase_cost = Helper::ParseFloat(e(Input::get('purchase_cost'))); } - $consumable->qty = e(Input::get('qty')); + $consumable->qty = Helper::ParseFloat(e(Input::get('qty'))); if ($consumable->save()) { return redirect()->to("admin/consumables")->with('success', trans('admin/consumables/message.update.success')); diff --git a/app/Http/Controllers/LicensesController.php b/app/Http/Controllers/LicensesController.php index b92f7a3c4..ec2720df9 100755 --- a/app/Http/Controllers/LicensesController.php +++ b/app/Http/Controllers/LicensesController.php @@ -87,17 +87,13 @@ class LicensesController extends Controller public function postCreate() { - - // get the POST data - $new = Input::all(); - // create a new model instance $license = new License(); if (e(Input::get('purchase_cost')) == '') { $license->purchase_cost = null; } else { - $license->purchase_cost = e(Input::get('purchase_cost')); + $license->purchase_cost = Helper::ParseFloat(e(Input::get('purchase_cost'))); } if (e(Input::get('supplier_id')) == '') { @@ -289,10 +285,9 @@ class LicensesController extends Controller } if (e(Input::get('purchase_cost')) == '') { - $license->purchase_cost = null; + $license->purchase_cost = null; } else { - $license->purchase_cost = e(Input::get('purchase_cost')); - //$license->purchase_cost = e(Input::get('purchase_cost')); + $license->purchase_cost = Helper::ParseFloat(e(Input::get('purchase_cost'))); } if (e(Input::get('maintained')) == '') { From b90c0de82264d958bcf1bad3e74bf57a51e617cd Mon Sep 17 00:00:00 2001 From: snipe Date: Tue, 27 Sep 2016 19:07:45 -0700 Subject: [PATCH 10/10] Fix companyable reult in maintenances --- app/Http/Controllers/AssetMaintenancesController.php | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/app/Http/Controllers/AssetMaintenancesController.php b/app/Http/Controllers/AssetMaintenancesController.php index ea2a1bcce..aa40376c6 100644 --- a/app/Http/Controllers/AssetMaintenancesController.php +++ b/app/Http/Controllers/AssetMaintenancesController.php @@ -141,7 +141,7 @@ class AssetMaintenancesController extends Controller 'completion_date' => $maintenance->completion_date, 'user_id' => ($maintenance->admin) ? (string)link_to('/admin/users/'.$maintenance->admin->id.'/view', $maintenance->admin->fullName()) : '', 'actions' => $actions, - 'companyName' => ($maintenance->asset) ? $maintenance->asset->company->name : '' + 'companyName' => ($maintenance->asset->company) ? $maintenance->asset->company->name : '' ); }