From 9818d1683412b3c9617c2cde12a72cce7a5d3439 Mon Sep 17 00:00:00 2001 From: Dampfklon Date: Wed, 16 Mar 2022 20:20:46 +0100 Subject: [PATCH] fix showDeletedFunction by reverting #9508 --- app/Http/Controllers/ReportsController.php | 13 +++++++++---- 1 file changed, 9 insertions(+), 4 deletions(-) diff --git a/app/Http/Controllers/ReportsController.php b/app/Http/Controllers/ReportsController.php index 3b242f093..191f37156 100644 --- a/app/Http/Controllers/ReportsController.php +++ b/app/Http/Controllers/ReportsController.php @@ -933,12 +933,17 @@ class ReportsController extends Controller /** * Get all assets with pending checkout acceptances */ - - $acceptances = CheckoutAcceptance::pending()->with('assignedTo')->get(); + if($showDeleted) { + $acceptances = CheckoutAcceptance::pending()->withTrashed()->with(['assignedTo' , 'checkoutable.assignedTo', 'checkoutable.model'])->get(); + } else { + $acceptances = CheckoutAcceptance::pending()->with(['assignedTo' => function ($query) { + $query->withTrashed(); + }, 'checkoutable.assignedTo', 'checkoutable.model'])->get(); + } $assetsForReport = $acceptances - ->filter(function($acceptance) { - return $acceptance->checkoutable_type == 'App\Models\Asset' && !is_null($acceptance->assignedTo); + ->filter(function ($acceptance) { + return $acceptance->checkoutable_type == 'App\Models\Asset'; }) ->map(function($acceptance) { return ['assetItem' => $acceptance->checkoutable, 'acceptance' => $acceptance];