From 5e5ba54c3e1a319d9b9bbeafc99a8a4b304a383f Mon Sep 17 00:00:00 2001 From: snipe Date: Fri, 23 Feb 2018 05:52:19 -0800 Subject: [PATCH 1/2] Disallow checkout asset to itself --- app/Http/Controllers/AssetsController.php | 6 ++++++ 1 file changed, 6 insertions(+) diff --git a/app/Http/Controllers/AssetsController.php b/app/Http/Controllers/AssetsController.php index e65025ae1..dff70ebbe 100755 --- a/app/Http/Controllers/AssetsController.php +++ b/app/Http/Controllers/AssetsController.php @@ -460,8 +460,14 @@ class AssetsController extends Controller $asset->location_id = ($target) ? $target->id : ''; } elseif (request('checkout_to_type')=='asset') { + + if (request('assigned_asset') == $assetId) { + return redirect()->back()->with('error', 'You cannot check an asset out to itself.'); + } + $target = Asset::where('id','!=',$assetId)->find(request('assigned_asset')); $asset->location_id = $target->rtd_location_id; + // Override with the asset's location_id if it has one if ($target->location_id!='') { $asset->location_id = ($target) ? $target->location_id : ''; From 0e48837eec90679d4332d2a07146bfbbcc5a72d5 Mon Sep 17 00:00:00 2001 From: snipe Date: Fri, 23 Feb 2018 05:53:00 -0800 Subject: [PATCH 2/2] Fixed assets checked out to assets listing table --- resources/views/hardware/view.blade.php | 25 ++++++++++++--------- resources/views/statuslabels/view.blade.php | 2 +- 2 files changed, 16 insertions(+), 11 deletions(-) diff --git a/resources/views/hardware/view.blade.php b/resources/views/hardware/view.blade.php index f01797ef5..5e79e4015 100755 --- a/resources/views/hardware/view.blade.php +++ b/resources/views/hardware/view.blade.php @@ -627,19 +627,24 @@
+ data-export-options='{ + "fileName": "export-assets-{{ str_slug($asset->name) }}-assets-{{ date('Y-m-d') }}", + "ignoreColumn": ["actions","image","change","checkbox","checkincheckout","icon"] + }'> +
diff --git a/resources/views/statuslabels/view.blade.php b/resources/views/statuslabels/view.blade.php index 331c9ee8a..b0e08d074 100644 --- a/resources/views/statuslabels/view.blade.php +++ b/resources/views/statuslabels/view.blade.php @@ -46,7 +46,7 @@ class="table table-striped snipe-table" data-url="{{route('api.assets.index', ['status_id' => $statuslabel->id]) }}" data-export-options='{ - "fileName": "export-locations-{{ str_slug($statuslabel->name) }}-assets-{{ date('Y-m-d') }}", + "fileName": "export-assets-{{ str_slug($statuslabel->name) }}-assets-{{ date('Y-m-d') }}", "ignoreColumn": ["actions","image","change","checkbox","checkincheckout","icon"] }'>