From ca59bc3c9ced6e0640f0e73fe5cd27a50d6ee823 Mon Sep 17 00:00:00 2001 From: Godfrey M Date: Tue, 6 Feb 2024 12:46:17 -0800 Subject: [PATCH 1/4] removes if statement that prevents select2-ifying inputs --- resources/assets/js/snipeit.js | 6 ++---- resources/views/users/confirm-bulk-delete.blade.php | 1 - 2 files changed, 2 insertions(+), 5 deletions(-) diff --git a/resources/assets/js/snipeit.js b/resources/assets/js/snipeit.js index a834e22ba..c82481658 100755 --- a/resources/assets/js/snipeit.js +++ b/resources/assets/js/snipeit.js @@ -191,9 +191,7 @@ $(document).ready(function () { * Select2 */ - var iOS = /iPhone|iPad|iPod/.test(navigator.userAgent) && !window.MSStream; - if(!iOS) - { + // Vue collision: Avoid overriding a vue select2 instance // by checking to see if the item has already been select2'd. $('select.select2:not(".select2-hidden-accessible")').each(function (i,obj) { @@ -201,7 +199,7 @@ $(document).ready(function () { $(obj).select2(); } }); - } + // $('.datepicker').datepicker(); // var datepicker = $.fn.datepicker.noConflict(); // return $.fn.datepicker to previously assigned value diff --git a/resources/views/users/confirm-bulk-delete.blade.php b/resources/views/users/confirm-bulk-delete.blade.php index bd6103ea9..cb80393e1 100644 --- a/resources/views/users/confirm-bulk-delete.blade.php +++ b/resources/views/users/confirm-bulk-delete.blade.php @@ -132,7 +132,6 @@ $(":submit").attr("disabled", "disabled"); //The line below needs to be here because in mobile view the status_id select2 forgets its select2 so this makes it function properly. - $("[name='status_id']").select2(); $("[name='status_id']").on('select2:select', function (e) { if (e.params.data.id != "") { console.log(e.params.data.id); From cfe2277a6492f412d5a722da57e07dc000562661 Mon Sep 17 00:00:00 2001 From: Godfrey M Date: Tue, 6 Feb 2024 13:05:04 -0800 Subject: [PATCH 2/4] forgot to remove comment line --- public/js/build/app.js | 18 +++++++----------- public/js/dist/all.js | 18 +++++++----------- public/mix-manifest.json | 4 ++-- .../views/users/confirm-bulk-delete.blade.php | 1 - 4 files changed, 16 insertions(+), 25 deletions(-) diff --git a/public/js/build/app.js b/public/js/build/app.js index 2332ec657..95d298bd0 100644 --- a/public/js/build/app.js +++ b/public/js/build/app.js @@ -1052,23 +1052,19 @@ $(document).ready(function () { * Select2 */ - var iOS = /iPhone|iPad|iPod/.test(navigator.userAgent) && !window.MSStream; + var iOS = /iPhone|iPad|iPod/.test(navigator.userAgent) && !window.MSStream; // Vue collision: Avoid overriding a vue select2 instance + // by checking to see if the item has already been select2'd. - if (!iOS) { - // Vue collision: Avoid overriding a vue select2 instance - // by checking to see if the item has already been select2'd. - $('select.select2:not(".select2-hidden-accessible")').each(function (i, obj) { - { - $(obj).select2(); - } - }); - } // $('.datepicker').datepicker(); + $('select.select2:not(".select2-hidden-accessible")').each(function (i, obj) { + { + $(obj).select2(); + } + }); // $('.datepicker').datepicker(); // var datepicker = $.fn.datepicker.noConflict(); // return $.fn.datepicker to previously assigned value // $.fn.bootstrapDP = datepicker; // $('.datepicker').datepicker(); // Crazy select2 rich dropdowns with images! - $('.js-data-ajax').each(function (i, item) { var link = $(item); var endpoint = link.data("endpoint"); diff --git a/public/js/dist/all.js b/public/js/dist/all.js index 80168a1a6..db19337be 100644 --- a/public/js/dist/all.js +++ b/public/js/dist/all.js @@ -60923,23 +60923,19 @@ $(document).ready(function () { * Select2 */ - var iOS = /iPhone|iPad|iPod/.test(navigator.userAgent) && !window.MSStream; + var iOS = /iPhone|iPad|iPod/.test(navigator.userAgent) && !window.MSStream; // Vue collision: Avoid overriding a vue select2 instance + // by checking to see if the item has already been select2'd. - if (!iOS) { - // Vue collision: Avoid overriding a vue select2 instance - // by checking to see if the item has already been select2'd. - $('select.select2:not(".select2-hidden-accessible")').each(function (i, obj) { - { - $(obj).select2(); - } - }); - } // $('.datepicker').datepicker(); + $('select.select2:not(".select2-hidden-accessible")').each(function (i, obj) { + { + $(obj).select2(); + } + }); // $('.datepicker').datepicker(); // var datepicker = $.fn.datepicker.noConflict(); // return $.fn.datepicker to previously assigned value // $.fn.bootstrapDP = datepicker; // $('.datepicker').datepicker(); // Crazy select2 rich dropdowns with images! - $('.js-data-ajax').each(function (i, item) { var link = $(item); var endpoint = link.data("endpoint"); diff --git a/public/mix-manifest.json b/public/mix-manifest.json index f84c4b826..c4884fe4c 100644 --- a/public/mix-manifest.json +++ b/public/mix-manifest.json @@ -1,5 +1,5 @@ { - "/js/build/app.js": "/js/build/app.js?id=41293fc7aa00ece89fd524e1e0e31a68", + "/js/build/app.js": "/js/build/app.js?id=5fc236a8a8e31c794f02425419889d4a", "/css/dist/skins/skin-blue.css": "/css/dist/skins/skin-blue.css?id=f677207c6cf9678eb539abecb408c374", "/css/build/overrides.css": "/css/build/overrides.css?id=9a69d65b9f2b35e6d17c6a72e76424d5", "/css/build/app.css": "/css/build/app.css?id=5a516232bc9f1488514577cf3c8108eb", @@ -32,7 +32,7 @@ "/css/dist/bootstrap-table.css": "/css/dist/bootstrap-table.css?id=afa255bf30b2a7c11a97e3165128d183", "/js/build/vendor.js": "/js/build/vendor.js?id=a2b971da417306a63385c8098acfe4af", "/js/dist/bootstrap-table.js": "/js/dist/bootstrap-table.js?id=29340c70d13855fa0165cd4d799c6f5b", - "/js/dist/all.js": "/js/dist/all.js?id=7588c5db6df57ae2c6bb6d7ac2ac5b55", + "/js/dist/all.js": "/js/dist/all.js?id=f2cfedbb15a56ef1d0cd57e2bca8a037", "/js/dist/all-defer.js": "/js/dist/all-defer.js?id=7f9a130eda6916eaa32a0a57e81918f3", "/css/dist/skins/skin-green.min.css": "/css/dist/skins/skin-green.min.css?id=0a82a6ae6bb4e58fe62d162c4fb50397", "/css/dist/skins/skin-green-dark.min.css": "/css/dist/skins/skin-green-dark.min.css?id=d419cb63a12dc175d71645c876bfc2ab", diff --git a/resources/views/users/confirm-bulk-delete.blade.php b/resources/views/users/confirm-bulk-delete.blade.php index cb80393e1..210f1420a 100644 --- a/resources/views/users/confirm-bulk-delete.blade.php +++ b/resources/views/users/confirm-bulk-delete.blade.php @@ -131,7 +131,6 @@ $(":submit").attr("disabled", "disabled"); - //The line below needs to be here because in mobile view the status_id select2 forgets its select2 so this makes it function properly. $("[name='status_id']").on('select2:select', function (e) { if (e.params.data.id != "") { console.log(e.params.data.id); From b73e8642d39faa4be1044e406945987497db9d77 Mon Sep 17 00:00:00 2001 From: Godfrey M Date: Tue, 6 Feb 2024 13:06:21 -0800 Subject: [PATCH 3/4] removed unnecessary changes --- public/js/build/app.js | 18 +++++++++++------- public/js/dist/all.js | 18 +++++++++++------- public/mix-manifest.json | 4 ++-- 3 files changed, 24 insertions(+), 16 deletions(-) diff --git a/public/js/build/app.js b/public/js/build/app.js index 95d298bd0..2332ec657 100644 --- a/public/js/build/app.js +++ b/public/js/build/app.js @@ -1052,19 +1052,23 @@ $(document).ready(function () { * Select2 */ - var iOS = /iPhone|iPad|iPod/.test(navigator.userAgent) && !window.MSStream; // Vue collision: Avoid overriding a vue select2 instance - // by checking to see if the item has already been select2'd. + var iOS = /iPhone|iPad|iPod/.test(navigator.userAgent) && !window.MSStream; - $('select.select2:not(".select2-hidden-accessible")').each(function (i, obj) { - { - $(obj).select2(); - } - }); // $('.datepicker').datepicker(); + if (!iOS) { + // Vue collision: Avoid overriding a vue select2 instance + // by checking to see if the item has already been select2'd. + $('select.select2:not(".select2-hidden-accessible")').each(function (i, obj) { + { + $(obj).select2(); + } + }); + } // $('.datepicker').datepicker(); // var datepicker = $.fn.datepicker.noConflict(); // return $.fn.datepicker to previously assigned value // $.fn.bootstrapDP = datepicker; // $('.datepicker').datepicker(); // Crazy select2 rich dropdowns with images! + $('.js-data-ajax').each(function (i, item) { var link = $(item); var endpoint = link.data("endpoint"); diff --git a/public/js/dist/all.js b/public/js/dist/all.js index db19337be..80168a1a6 100644 --- a/public/js/dist/all.js +++ b/public/js/dist/all.js @@ -60923,19 +60923,23 @@ $(document).ready(function () { * Select2 */ - var iOS = /iPhone|iPad|iPod/.test(navigator.userAgent) && !window.MSStream; // Vue collision: Avoid overriding a vue select2 instance - // by checking to see if the item has already been select2'd. + var iOS = /iPhone|iPad|iPod/.test(navigator.userAgent) && !window.MSStream; - $('select.select2:not(".select2-hidden-accessible")').each(function (i, obj) { - { - $(obj).select2(); - } - }); // $('.datepicker').datepicker(); + if (!iOS) { + // Vue collision: Avoid overriding a vue select2 instance + // by checking to see if the item has already been select2'd. + $('select.select2:not(".select2-hidden-accessible")').each(function (i, obj) { + { + $(obj).select2(); + } + }); + } // $('.datepicker').datepicker(); // var datepicker = $.fn.datepicker.noConflict(); // return $.fn.datepicker to previously assigned value // $.fn.bootstrapDP = datepicker; // $('.datepicker').datepicker(); // Crazy select2 rich dropdowns with images! + $('.js-data-ajax').each(function (i, item) { var link = $(item); var endpoint = link.data("endpoint"); diff --git a/public/mix-manifest.json b/public/mix-manifest.json index c4884fe4c..f84c4b826 100644 --- a/public/mix-manifest.json +++ b/public/mix-manifest.json @@ -1,5 +1,5 @@ { - "/js/build/app.js": "/js/build/app.js?id=5fc236a8a8e31c794f02425419889d4a", + "/js/build/app.js": "/js/build/app.js?id=41293fc7aa00ece89fd524e1e0e31a68", "/css/dist/skins/skin-blue.css": "/css/dist/skins/skin-blue.css?id=f677207c6cf9678eb539abecb408c374", "/css/build/overrides.css": "/css/build/overrides.css?id=9a69d65b9f2b35e6d17c6a72e76424d5", "/css/build/app.css": "/css/build/app.css?id=5a516232bc9f1488514577cf3c8108eb", @@ -32,7 +32,7 @@ "/css/dist/bootstrap-table.css": "/css/dist/bootstrap-table.css?id=afa255bf30b2a7c11a97e3165128d183", "/js/build/vendor.js": "/js/build/vendor.js?id=a2b971da417306a63385c8098acfe4af", "/js/dist/bootstrap-table.js": "/js/dist/bootstrap-table.js?id=29340c70d13855fa0165cd4d799c6f5b", - "/js/dist/all.js": "/js/dist/all.js?id=f2cfedbb15a56ef1d0cd57e2bca8a037", + "/js/dist/all.js": "/js/dist/all.js?id=7588c5db6df57ae2c6bb6d7ac2ac5b55", "/js/dist/all-defer.js": "/js/dist/all-defer.js?id=7f9a130eda6916eaa32a0a57e81918f3", "/css/dist/skins/skin-green.min.css": "/css/dist/skins/skin-green.min.css?id=0a82a6ae6bb4e58fe62d162c4fb50397", "/css/dist/skins/skin-green-dark.min.css": "/css/dist/skins/skin-green-dark.min.css?id=d419cb63a12dc175d71645c876bfc2ab", From c4eaae923a723515a42db2105d4b932ca7a9fc7a Mon Sep 17 00:00:00 2001 From: Godfrey M Date: Thu, 8 Feb 2024 15:02:47 -0800 Subject: [PATCH 4/4] removed vue comments since they do not apply anymore --- resources/assets/js/snipeit.js | 3 --- 1 file changed, 3 deletions(-) diff --git a/resources/assets/js/snipeit.js b/resources/assets/js/snipeit.js index c82481658..f5d986def 100755 --- a/resources/assets/js/snipeit.js +++ b/resources/assets/js/snipeit.js @@ -191,9 +191,6 @@ $(document).ready(function () { * Select2 */ - - // Vue collision: Avoid overriding a vue select2 instance - // by checking to see if the item has already been select2'd. $('select.select2:not(".select2-hidden-accessible")').each(function (i,obj) { { $(obj).select2();