From 842dafefec33b4d6513fa3cedf273b4904b6feda Mon Sep 17 00:00:00 2001 From: Godfrey M Date: Mon, 1 Aug 2022 14:52:12 -0700 Subject: [PATCH 01/27] adds options to include Deleted assets to custom asset reports --- app/Http/Controllers/ReportsController.php | 6 ++++++ resources/lang/en/general.php | 2 ++ resources/views/reports/custom.blade.php | 12 ++++++++++++ 3 files changed, 20 insertions(+) diff --git a/app/Http/Controllers/ReportsController.php b/app/Http/Controllers/ReportsController.php index 74d709adc..03fdcb0d4 100644 --- a/app/Http/Controllers/ReportsController.php +++ b/app/Http/Controllers/ReportsController.php @@ -645,6 +645,12 @@ class ReportsController extends Controller if($request->filled('exclude_archived')){ $assets->notArchived(); } + if($request->filled('include_deleted')){ + $assets->withTrashed(); + } + if($request->filled('only_deleted')){ + $assets->onlyTrashed(); + } $assets->orderBy('assets.id', 'ASC')->chunk(20, function ($assets) use ($handle, $customfields, $request) { diff --git a/resources/lang/en/general.php b/resources/lang/en/general.php index 43e9e4fbe..c97d8133f 100644 --- a/resources/lang/en/general.php +++ b/resources/lang/en/general.php @@ -132,6 +132,7 @@ return [ 'id' => 'ID', 'image' => 'Image', 'image_delete' => 'Delete Image', + 'include_deleted' => 'Include Deleted Assets', 'image_upload' => 'Upload Image', 'filetypes_accepted_help' => 'Accepted filetype is :types. Max upload size allowed is :size.|Accepted filetypes are :types. Max upload size allowed is :size.', 'filetypes_size_help' => 'Max upload size allowed is :size.', @@ -185,6 +186,7 @@ return [ 'no' => 'No', 'notes' => 'Notes', 'order_number' => 'Order Number', + 'only_deleted' => 'Only Deleted Assets', 'page_menu' => 'Showing _MENU_ items', 'pagination_info' => 'Showing _START_ to _END_ of _TOTAL_ items', 'pending' => 'Pending', diff --git a/resources/views/reports/custom.blade.php b/resources/views/reports/custom.blade.php index b281595d0..b58efaf4a 100644 --- a/resources/views/reports/custom.blade.php +++ b/resources/views/reports/custom.blade.php @@ -351,6 +351,18 @@ {{ trans('general.bom_remark') }} +
+ +
+
+ +
From b0350035465c1a2f053c82b5c3ba59c414ef5ec5 Mon Sep 17 00:00:00 2001 From: snipe Date: Mon, 1 Aug 2022 15:59:54 -0700 Subject: [PATCH 02/27] Handled hardware route names Signed-off-by: snipe --- app/Http/Controllers/Assets/BulkAssetsController.php | 6 +++--- resources/views/hardware/checkin.blade.php | 4 ++-- resources/views/hardware/view.blade.php | 4 ++-- resources/views/layouts/default.blade.php | 2 +- routes/web/hardware.php | 12 ++++++------ 5 files changed, 14 insertions(+), 14 deletions(-) diff --git a/app/Http/Controllers/Assets/BulkAssetsController.php b/app/Http/Controllers/Assets/BulkAssetsController.php index 5053fca0b..270d54cf2 100644 --- a/app/Http/Controllers/Assets/BulkAssetsController.php +++ b/app/Http/Controllers/Assets/BulkAssetsController.php @@ -250,7 +250,7 @@ class BulkAssetsController extends Controller $target = $this->determineCheckoutTarget(); if (! is_array($request->get('selected_assets'))) { - return redirect()->route('hardware/bulkcheckout')->withInput()->with('error', trans('admin/hardware/message.checkout.no_assets_selected')); + return redirect()->route('hardware.bulkcheckout.show')->withInput()->with('error', trans('admin/hardware/message.checkout.no_assets_selected')); } $asset_ids = array_filter($request->get('selected_assets')); @@ -297,9 +297,9 @@ class BulkAssetsController extends Controller return redirect()->to('hardware')->with('success', trans('admin/hardware/message.checkout.success')); } // Redirect to the asset management page with error - return redirect()->to('hardware/bulk-checkout')->with('error', trans('admin/hardware/message.checkout.error'))->withErrors($errors); + return redirect()->route('hardware.bulkcheckout.show')->with('error', trans('admin/hardware/message.checkout.error'))->withErrors($errors); } catch (ModelNotFoundException $e) { - return redirect()->to('hardware/bulk-checkout')->with('error', $e->getErrors()); + return redirect()->route('hardware.bulkcheckout.show')->with('error', $e->getErrors()); } } } diff --git a/resources/views/hardware/checkin.blade.php b/resources/views/hardware/checkin.blade.php index ff2d08e52..c39704289 100755 --- a/resources/views/hardware/checkin.blade.php +++ b/resources/views/hardware/checkin.blade.php @@ -28,11 +28,11 @@
@if ($backto=='user')
@else + action="{{ route('hardware.checkin.store', array('assetId'=> $asset->id)) }}" autocomplete="off"> @endif {{csrf_field()}} diff --git a/resources/views/hardware/view.blade.php b/resources/views/hardware/view.blade.php index 4ebdfd7f5..a1452767d 100755 --- a/resources/views/hardware/view.blade.php +++ b/resources/views/hardware/view.blade.php @@ -22,7 +22,7 @@ @if (($asset->assigned_to != '') && ($asset->deleted_at=='')) @can('checkin', \App\Models\Asset::class)
  • - + {{ trans('admin/hardware/general.checkin') }}
  • @@ -30,7 +30,7 @@ @elseif (($asset->assigned_to == '') && ($asset->deleted_at=='')) @can('checkout', \App\Models\Asset::class)
  • - + {{ trans('admin/hardware/general.checkout') }}
  • diff --git a/resources/views/layouts/default.blade.php b/resources/views/layouts/default.blade.php index 2379b1f55..2d53c2aac 100644 --- a/resources/views/layouts/default.blade.php +++ b/resources/views/layouts/default.blade.php @@ -486,7 +486,7 @@ @can('checkout', \App\Models\Asset::class) - + {{ trans('general.bulk_checkout') }} diff --git a/routes/web/hardware.php b/routes/web/hardware.php index 2ef397894..09811d17d 100644 --- a/routes/web/hardware.php +++ b/routes/web/hardware.php @@ -108,19 +108,19 @@ Route::group( Route::get('{assetId}/checkout', [AssetCheckoutController::class, 'create'] - )->name('checkout/hardware'); + )->name('hardware.checkout.create'); Route::post('{assetId}/checkout', [AssetCheckoutController::class, 'store'] - )->name('checkout/hardware'); + )->name('hardware.checkout.store'); Route::get('{assetId}/checkin/{backto?}', [AssetCheckinController::class, 'create'] - )->name('checkin/hardware'); + )->name('hardware.checkin.create'); Route::post('{assetId}/checkin/{backto?}', [AssetCheckinController::class, 'store'] - )->name('checkin/hardware'); + )->name('hardware.checkin.store'); Route::get('{assetId}/view', [AssetsController::class, 'show'] @@ -168,11 +168,11 @@ Route::group( // Bulk checkout / checkin Route::get('bulkcheckout', [BulkAssetsController::class, 'showCheckout'] - )->name('hardware/bulkcheckout'); + )->name('hardware.bulkcheckout.show'); Route::post('bulkcheckout', [BulkAssetsController::class, 'storeCheckout'] - )->name('hardware/bulkcheckout'); + )->name('hardware.bulkcheckout.store'); }); Route::resource('hardware', From 744d0d299e8f2673520d8deda2dab04b6d66b1ab Mon Sep 17 00:00:00 2001 From: snipe Date: Mon, 1 Aug 2022 16:03:45 -0700 Subject: [PATCH 03/27] Handle model route names Signed-off-by: snipe --- resources/views/models/view.blade.php | 6 +++--- routes/web/models.php | 6 +++--- 2 files changed, 6 insertions(+), 6 deletions(-) diff --git a/resources/views/models/view.blade.php b/resources/views/models/view.blade.php index c929aeda8..82bb6cd50 100755 --- a/resources/views/models/view.blade.php +++ b/resources/views/models/view.blade.php @@ -16,10 +16,10 @@
    @@ -316,7 +316,7 @@ @can('create', \App\Models\AssetModel::class) @endcan diff --git a/routes/web/models.php b/routes/web/models.php index 2643f02d2..37e54995b 100644 --- a/routes/web/models.php +++ b/routes/web/models.php @@ -28,7 +28,7 @@ Route::group(['prefix' => 'models', 'middleware' => ['auth']], function () { AssetModelsController::class, 'getClone' ] - )->name('clone/model'); + )->name('models.clone.create'); Route::post( '{modelId}/clone', @@ -36,7 +36,7 @@ Route::group(['prefix' => 'models', 'middleware' => ['auth']], function () { AssetModelsController::class, 'postCreate' ] - )->name('clone/model'); + )->name('models.clone.store'); Route::get( '{modelId}/view', @@ -52,7 +52,7 @@ Route::group(['prefix' => 'models', 'middleware' => ['auth']], function () { AssetModelsController::class, 'getRestore' ] - )->name('restore/model'); + )->name('models.restore.store'); Route::get( '{modelId}/custom_fields', From 4a4636bd03337415f54779719d3b87e99f3caecc Mon Sep 17 00:00:00 2001 From: snipe Date: Mon, 1 Aug 2022 16:06:28 -0700 Subject: [PATCH 04/27] Handle accessories route names Signed-off-by: snipe --- .../Accessories/AccessoryCheckoutController.php | 2 +- resources/views/accessories/view.blade.php | 6 +++--- routes/web/accessories.php | 8 ++++---- 3 files changed, 8 insertions(+), 8 deletions(-) diff --git a/app/Http/Controllers/Accessories/AccessoryCheckoutController.php b/app/Http/Controllers/Accessories/AccessoryCheckoutController.php index 7eb9b39a4..6144bb6f9 100644 --- a/app/Http/Controllers/Accessories/AccessoryCheckoutController.php +++ b/app/Http/Controllers/Accessories/AccessoryCheckoutController.php @@ -63,7 +63,7 @@ class AccessoryCheckoutController extends Controller $this->authorize('checkout', $accessory); if (! $user = User::find($request->input('assigned_to'))) { - return redirect()->route('checkout/accessory', $accessory->id)->with('error', trans('admin/accessories/message.checkout.user_does_not_exist')); + return redirect()->route('accessories.checkout.show', $accessory->id)->with('error', trans('admin/accessories/message.checkout.user_does_not_exist')); } // Update the accessory data diff --git a/resources/views/accessories/view.blade.php b/resources/views/accessories/view.blade.php index 7132e7ede..f00bee3e6 100644 --- a/resources/views/accessories/view.blade.php +++ b/resources/views/accessories/view.blade.php @@ -24,13 +24,13 @@ @if ($accessory->assigned_to != '') @can('checkin', \App\Models\Accessory::class)
  • - {{ trans('admin/accessories/general.checkin') }} + {{ trans('admin/accessories/general.checkin') }}
  • @endcan @else @can('checkout', \App\Models\Accessory::class)
  • - {{ trans('admin/accessories/general.checkout') }} + {{ trans('admin/accessories/general.checkout') }}
  • @endcan @endif @@ -171,7 +171,7 @@ @can('checkout', \App\Models\Accessory::class) @endcan diff --git a/routes/web/accessories.php b/routes/web/accessories.php index c0df30598..c250c122d 100644 --- a/routes/web/accessories.php +++ b/routes/web/accessories.php @@ -10,22 +10,22 @@ Route::group(['prefix' => 'accessories', 'middleware' => ['auth']], function () Route::get( '{accessoryID}/checkout', [Accessories\AccessoryCheckoutController::class, 'create'] - )->name('checkout/accessory'); + )->name('accessories.checkout.show'); Route::post( '{accessoryID}/checkout', [Accessories\AccessoryCheckoutController::class, 'store'] - )->name('checkout/accessory'); + )->name('accessories.checkout.store'); Route::get( '{accessoryID}/checkin/{backto?}', [Accessories\AccessoryCheckinController::class, 'create'] - )->name('checkin/accessory'); + )->name('accessories.checkin.show'); Route::post( '{accessoryID}/checkin/{backto?}', [Accessories\AccessoryCheckinController::class, 'store'] - )->name('checkin/accessory'); + )->name('accessories.checkin.store'); }); From 53ff28d2b0d03a91c85ceb1c978a9095619dd2f2 Mon Sep 17 00:00:00 2001 From: snipe Date: Mon, 1 Aug 2022 16:07:56 -0700 Subject: [PATCH 05/27] Handle consumables route names Signed-off-by: snipe --- .../Controllers/Consumables/ConsumableCheckoutController.php | 2 +- resources/views/consumables/view.blade.php | 2 +- routes/web/consumables.php | 4 ++-- 3 files changed, 4 insertions(+), 4 deletions(-) diff --git a/app/Http/Controllers/Consumables/ConsumableCheckoutController.php b/app/Http/Controllers/Consumables/ConsumableCheckoutController.php index 03ca2f205..48cb6ac76 100644 --- a/app/Http/Controllers/Consumables/ConsumableCheckoutController.php +++ b/app/Http/Controllers/Consumables/ConsumableCheckoutController.php @@ -56,7 +56,7 @@ class ConsumableCheckoutController extends Controller // Check if the user exists if (is_null($user = User::find($assigned_to))) { // Redirect to the consumable management page with error - return redirect()->route('checkout/consumable', $consumable)->with('error', trans('admin/consumables/message.checkout.user_does_not_exist')); + return redirect()->route('consumables.checkout.show', $consumable)->with('error', trans('admin/consumables/message.checkout.user_does_not_exist')); } // Update the consumable data diff --git a/resources/views/consumables/view.blade.php b/resources/views/consumables/view.blade.php index 958c0e1ee..cacab8b26 100644 --- a/resources/views/consumables/view.blade.php +++ b/resources/views/consumables/view.blade.php @@ -127,7 +127,7 @@ @can('checkout', \App\Models\Consumable::class) @endcan diff --git a/routes/web/consumables.php b/routes/web/consumables.php index 17e59df8a..9f930a968 100644 --- a/routes/web/consumables.php +++ b/routes/web/consumables.php @@ -9,12 +9,12 @@ Route::group(['prefix' => 'consumables', 'middleware' => ['auth']], function () Route::get( '{consumablesID}/checkout', [Consumables\ConsumableCheckoutController::class, 'create'] - )->name('checkout/consumable'); + )->name('consumables.checkout.show'); Route::post( '{consumablesID}/checkout', [Consumables\ConsumableCheckoutController::class, 'store'] - )->name('checkout/consumable'); + )->name('consumables.checkout.store'); }); From 5e488bd81f8da2df03800ed7d96656ba4e070dbf Mon Sep 17 00:00:00 2001 From: snipe Date: Mon, 1 Aug 2022 16:10:39 -0700 Subject: [PATCH 06/27] Handle components route names Signed-off-by: snipe --- resources/views/components/checkin.blade.php | 2 +- resources/views/components/view.blade.php | 2 +- routes/web/components.php | 8 ++++---- 3 files changed, 6 insertions(+), 6 deletions(-) diff --git a/resources/views/components/checkin.blade.php b/resources/views/components/checkin.blade.php index 9b8624c24..8dca26044 100644 --- a/resources/views/components/checkin.blade.php +++ b/resources/views/components/checkin.blade.php @@ -17,7 +17,7 @@
    - + {{csrf_field()}}
    diff --git a/resources/views/components/view.blade.php b/resources/views/components/view.blade.php index cf1cd66bd..2ffb6bdce 100644 --- a/resources/views/components/view.blade.php +++ b/resources/views/components/view.blade.php @@ -29,7 +29,7 @@ @else @can('checkout', $component)
  • - + {{ trans('admin/components/general.checkout') }}
  • diff --git a/routes/web/components.php b/routes/web/components.php index aec4cb91b..6735c1abd 100644 --- a/routes/web/components.php +++ b/routes/web/components.php @@ -8,22 +8,22 @@ Route::group(['prefix' => 'components', 'middleware' => ['auth']], function () { Route::get( '{componentID}/checkout', [Components\ComponentCheckoutController::class, 'create'] - )->name('checkout/component'); + )->name('component.checkout.show'); Route::post( '{componentID}/checkout', [Components\ComponentCheckoutController::class, 'store'] - )->name('checkout/component'); + )->name('component.checkout.store'); Route::get( '{componentID}/checkin/{backto?}', [Components\ComponentCheckinController::class, 'create'] - )->name('checkin/component'); + )->name('component.checkin.show'); Route::post( '{componentID}/checkin/{backto?}', [Components\ComponentCheckinController::class, 'store'] - )->name('component.checkin.save'); + )->name('components.checkin.store'); }); From 3e48f436af24d259860f89dcd6d3ec5141f19d28 Mon Sep 17 00:00:00 2001 From: snipe Date: Mon, 1 Aug 2022 16:13:30 -0700 Subject: [PATCH 07/27] Handled user route names Signed-off-by: snipe --- resources/views/users/view.blade.php | 6 +++--- routes/web/users.php | 6 +++--- 2 files changed, 6 insertions(+), 6 deletions(-) diff --git a/resources/views/users/view.blade.php b/resources/views/users/view.blade.php index 8763c5718..7795c5dbc 100755 --- a/resources/views/users/view.blade.php +++ b/resources/views/users/view.blade.php @@ -113,7 +113,7 @@
    @else
    - + @csrf diff --git a/routes/web/users.php b/routes/web/users.php index 320ed2534..0183d48dc 100644 --- a/routes/web/users.php +++ b/routes/web/users.php @@ -38,7 +38,7 @@ Route::group(['prefix' => 'users', 'middleware' => ['auth']], function () { Users\UsersController::class, 'getClone' ] - )->name('clone/user'); + )->name('users.clone.show'); Route::post( '{userId}/clone', @@ -46,7 +46,7 @@ Route::group(['prefix' => 'users', 'middleware' => ['auth']], function () { Users\UsersController::class, 'postCreate' ] - )->name('clone/user'); + )->name('users.clone.store'); Route::post( '{userId}/restore', @@ -54,7 +54,7 @@ Route::group(['prefix' => 'users', 'middleware' => ['auth']], function () { Users\UsersController::class, 'getRestore' ] - )->name('restore/user'); + )->name('users.restore.store'); Route::get( '{userId}/unsuspend', From af7ccf3beb238522d7930004d9f926cb6ea6149a Mon Sep 17 00:00:00 2001 From: snipe Date: Mon, 1 Aug 2022 16:17:40 -0700 Subject: [PATCH 08/27] Handle logout route names Signed-off-by: snipe --- app/Http/Controllers/Auth/SamlController.php | 2 +- resources/views/auth/two_factor.blade.php | 4 ++-- resources/views/layouts/default.blade.php | 4 ++-- routes/web.php | 4 ++-- 4 files changed, 7 insertions(+), 7 deletions(-) diff --git a/app/Http/Controllers/Auth/SamlController.php b/app/Http/Controllers/Auth/SamlController.php index 3d5cf75ec..b6218988e 100644 --- a/app/Http/Controllers/Auth/SamlController.php +++ b/app/Http/Controllers/Auth/SamlController.php @@ -142,6 +142,6 @@ class SamlController extends Controller return view('errors.403'); } - return redirect()->route('logout')->with(['saml_logout' => true,'saml_slo_redirect_url' => $sloUrl]); + return redirect()->route('logout.get')->with(['saml_logout' => true,'saml_slo_redirect_url' => $sloUrl]); } } diff --git a/resources/views/auth/two_factor.blade.php b/resources/views/auth/two_factor.blade.php index c61b4e064..d6c9d986e 100644 --- a/resources/views/auth/two_factor.blade.php +++ b/resources/views/auth/two_factor.blade.php @@ -42,13 +42,13 @@
    - diff --git a/resources/views/layouts/default.blade.php b/resources/views/layouts/default.blade.php index 2d53c2aac..85ec627a2 100644 --- a/resources/views/layouts/default.blade.php +++ b/resources/views/layouts/default.blade.php @@ -354,11 +354,11 @@
  • - + {{ trans('general.logout') }} - diff --git a/routes/web.php b/routes/web.php index b783c341f..249e02a36 100644 --- a/routes/web.php +++ b/routes/web.php @@ -467,12 +467,12 @@ Route::group(['middleware' => 'web'], function () { Route::get( 'logout', [LoginController::class, 'logout'] - )->name('logout'); + )->name('logout.get'); Route::post( 'logout', [LoginController::class, 'logout'] - )->name('logout'); + )->name('logout.post'); }); //Auth::routes(); From 0fdbd410b6565bb6945602b818ab6b8cdbea0531 Mon Sep 17 00:00:00 2001 From: snipe Date: Mon, 1 Aug 2022 17:10:39 -0700 Subject: [PATCH 09/27] Use unique_undeleted instead of unique for custom fields Signed-off-by: snipe --- app/Models/CustomFieldset.php | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/app/Models/CustomFieldset.php b/app/Models/CustomFieldset.php index 1cf1807d8..a2698d818 100644 --- a/app/Models/CustomFieldset.php +++ b/app/Models/CustomFieldset.php @@ -87,7 +87,7 @@ class CustomFieldset extends Model } if ($field->is_unique == '1') { - $rule[] = 'unique'; + $rule[] = 'unique_undeleted'; } array_push($rule, $field->attributes['format']); From e79a81972459bb89f3b53b372fc0c2a84521648d Mon Sep 17 00:00:00 2001 From: snipe Date: Mon, 1 Aug 2022 17:45:39 -0700 Subject: [PATCH 10/27] Fixed inconsistency in naming Signed-off-by: snipe --- resources/views/components/view.blade.php | 4 ++-- routes/web/components.php | 6 +++--- 2 files changed, 5 insertions(+), 5 deletions(-) diff --git a/resources/views/components/view.blade.php b/resources/views/components/view.blade.php index 2ffb6bdce..46ae20af0 100644 --- a/resources/views/components/view.blade.php +++ b/resources/views/components/view.blade.php @@ -21,7 +21,7 @@ @if ($component->assigned_to != '') @can('checkin', $component)
  • - + {{ trans('admin/components/general.checkin') }}
  • @@ -29,7 +29,7 @@ @else @can('checkout', $component)
  • - + {{ trans('admin/components/general.checkout') }}
  • diff --git a/routes/web/components.php b/routes/web/components.php index 6735c1abd..81302df15 100644 --- a/routes/web/components.php +++ b/routes/web/components.php @@ -8,17 +8,17 @@ Route::group(['prefix' => 'components', 'middleware' => ['auth']], function () { Route::get( '{componentID}/checkout', [Components\ComponentCheckoutController::class, 'create'] - )->name('component.checkout.show'); + )->name('components.checkout.show'); Route::post( '{componentID}/checkout', [Components\ComponentCheckoutController::class, 'store'] - )->name('component.checkout.store'); + )->name('components.checkout.store'); Route::get( '{componentID}/checkin/{backto?}', [Components\ComponentCheckinController::class, 'create'] - )->name('component.checkin.show'); + )->name('components.checkin.show'); Route::post( '{componentID}/checkin/{backto?}', From 4834c33861f8e0f657c57a18039cc792404c4231 Mon Sep 17 00:00:00 2001 From: snipe Date: Mon, 1 Aug 2022 18:43:54 -0700 Subject: [PATCH 11/27] Missed a named route Signed-off-by: snipe --- resources/views/users/view.blade.php | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/resources/views/users/view.blade.php b/resources/views/users/view.blade.php index 7795c5dbc..8e7b531ec 100755 --- a/resources/views/users/view.blade.php +++ b/resources/views/users/view.blade.php @@ -730,7 +730,7 @@ @can('checkin', $accessory) - {{ trans('general.checkin') }} + {{ trans('general.checkin') }} @endcan From 4133ac6ef02e85d179063a1256483fcbc94f77ec Mon Sep 17 00:00:00 2001 From: snipe Date: Mon, 1 Aug 2022 18:47:29 -0700 Subject: [PATCH 12/27] Applied date formatter to Current Date output on location print assigned Signed-off-by: snipe --- resources/views/locations/print.blade.php | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/resources/views/locations/print.blade.php b/resources/views/locations/print.blade.php index 7fc02ea6e..9c414af4c 100644 --- a/resources/views/locations/print.blade.php +++ b/resources/views/locations/print.blade.php @@ -58,7 +58,7 @@ @if ($manager) {{ trans('admin/locations/general.manager') }} {{ $manager->present()->fullName() }}
    @endif -{{ trans('admin/locations/general.date') }} {{ date("d/m/Y h:i:s A") }}

    +{{ trans('admin/locations/general.date') }} {{ \App\Helpers\Helper::getFormattedDateObject(now(), 'datetime', false) }}

    @if ($users->count() > 0) @php From e07532dd1bbc5419a2049000a6d7ba2ae3958a45 Mon Sep 17 00:00:00 2001 From: snipe Date: Mon, 1 Aug 2022 18:55:28 -0700 Subject: [PATCH 13/27] Applied master fix to develop Signed-off-by: snipe --- resources/views/locations/print.blade.php | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/resources/views/locations/print.blade.php b/resources/views/locations/print.blade.php index 9c414af4c..5586fe5cc 100644 --- a/resources/views/locations/print.blade.php +++ b/resources/views/locations/print.blade.php @@ -140,8 +140,8 @@ {{ ($asset->model) ? $asset->model->name : '' }} {{ $asset->serial }} {{ $asset->location->name }} - {{ $asset->last_checkout }} - {{ $asset->expected_checkin }} + {{ \App\Helpers\Helper::getFormattedDateObject( $asset->last_checkout, 'datetime', false) }} + {{ \App\Helpers\Helper::getFormattedDateObject( $asset->expected_checkin, 'datetime', false) }} @php $counter++ From 96b40a5edda5a9ebb34a3e8b1ab5589a2c02c3e1 Mon Sep 17 00:00:00 2001 From: vishalkumar183 Date: Tue, 2 Aug 2022 18:44:16 +0530 Subject: [PATCH 14/27] Error 404 fixed on sumitting witout mandtory field --- app/Http/Controllers/Assets/BulkAssetsController.php | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/app/Http/Controllers/Assets/BulkAssetsController.php b/app/Http/Controllers/Assets/BulkAssetsController.php index 5053fca0b..edf025746 100644 --- a/app/Http/Controllers/Assets/BulkAssetsController.php +++ b/app/Http/Controllers/Assets/BulkAssetsController.php @@ -12,6 +12,7 @@ use Illuminate\Http\Request; use Illuminate\Support\Facades\Auth; use Illuminate\Support\Facades\DB; use Illuminate\Support\Facades\Session; +use App\Http\Requests\AssetCheckoutRequest; class BulkAssetsController extends Controller { @@ -239,7 +240,7 @@ class BulkAssetsController extends Controller * Process Multiple Checkout Request * @return View */ - public function storeCheckout(Request $request) + public function storeCheckout(AssetCheckoutRequest $request) { $this->authorize('checkout', Asset::class); From a63d00bb5c4b1c824af2192be4b78716c3a83af2 Mon Sep 17 00:00:00 2001 From: Ivan Nieto Vivanco Date: Tue, 2 Aug 2022 11:55:11 -0500 Subject: [PATCH 15/27] Use apropiate string for license actions --- resources/views/licenses/view.blade.php | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/resources/views/licenses/view.blade.php b/resources/views/licenses/view.blade.php index 3f186f1bb..07c9d5e3a 100755 --- a/resources/views/licenses/view.blade.php +++ b/resources/views/licenses/view.blade.php @@ -78,8 +78,8 @@ @endcan @@ -575,4 +575,4 @@ @section('moar_scripts') @include ('partials.bootstrap-table') -@stop \ No newline at end of file +@stop From ff080a2d8f731546db7e1ef1fb8e62b96609b81f Mon Sep 17 00:00:00 2001 From: Godfrey M Date: Tue, 2 Aug 2022 10:27:55 -0700 Subject: [PATCH 16/27] replace checkboxes with radiobuttons --- app/Http/Controllers/ReportsController.php | 4 ++-- resources/lang/en/general.php | 1 + resources/views/reports/custom.blade.php | 16 +++++++++------- 3 files changed, 12 insertions(+), 9 deletions(-) diff --git a/app/Http/Controllers/ReportsController.php b/app/Http/Controllers/ReportsController.php index 03fdcb0d4..52032114e 100644 --- a/app/Http/Controllers/ReportsController.php +++ b/app/Http/Controllers/ReportsController.php @@ -645,10 +645,10 @@ class ReportsController extends Controller if($request->filled('exclude_archived')){ $assets->notArchived(); } - if($request->filled('include_deleted')){ + if($request->input('deleted_assets') == '1'){ $assets->withTrashed(); } - if($request->filled('only_deleted')){ + if($request->input('deleted_assets') == '0'){ $assets->onlyTrashed(); } diff --git a/resources/lang/en/general.php b/resources/lang/en/general.php index c97d8133f..8170697aa 100644 --- a/resources/lang/en/general.php +++ b/resources/lang/en/general.php @@ -102,6 +102,7 @@ return [ 'email_domain_help' => 'This is used to generate email addresses when importing', 'error' => 'Error', 'exclude_archived' => 'Exclude Archived Assets', + 'exclude_deleted' => 'Exclude All Deleted Assets', 'example' => 'Example: ', 'filastname_format' => 'First Initial Last Name (jsmith@example.com)', 'firstname_lastname_format' => 'First Name Last Name (jane.smith@example.com)', diff --git a/resources/views/reports/custom.blade.php b/resources/views/reports/custom.blade.php index b58efaf4a..fbd987817 100644 --- a/resources/views/reports/custom.blade.php +++ b/resources/views/reports/custom.blade.php @@ -351,15 +351,17 @@ {{ trans('general.bom_remark') }}
    +
    -
    -
    -
    From e150ab58e94f9e5fbc59cb6edfa033861f5a25b8 Mon Sep 17 00:00:00 2001 From: Godfrey M Date: Tue, 2 Aug 2022 10:31:06 -0700 Subject: [PATCH 17/27] reworded trans --- resources/lang/en/general.php | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/resources/lang/en/general.php b/resources/lang/en/general.php index 8170697aa..36b47c195 100644 --- a/resources/lang/en/general.php +++ b/resources/lang/en/general.php @@ -102,7 +102,7 @@ return [ 'email_domain_help' => 'This is used to generate email addresses when importing', 'error' => 'Error', 'exclude_archived' => 'Exclude Archived Assets', - 'exclude_deleted' => 'Exclude All Deleted Assets', + 'exclude_deleted' => 'Exclude Deleted Assets', 'example' => 'Example: ', 'filastname_format' => 'First Initial Last Name (jsmith@example.com)', 'firstname_lastname_format' => 'First Name Last Name (jane.smith@example.com)', From 13053b85efa03f28036e4d5b053c5f841d3a0969 Mon Sep 17 00:00:00 2001 From: Ivan Nieto Vivanco Date: Tue, 2 Aug 2022 12:37:27 -0500 Subject: [PATCH 18/27] Remove Actions button and pass the correct variable to the routes --- resources/views/licenses/view.blade.php | 19 ++----------------- 1 file changed, 2 insertions(+), 17 deletions(-) diff --git a/resources/views/licenses/view.blade.php b/resources/views/licenses/view.blade.php index 07c9d5e3a..b6408d7de 100755 --- a/resources/views/licenses/view.blade.php +++ b/resources/views/licenses/view.blade.php @@ -7,21 +7,6 @@ @parent @stop -{{-- Right header --}} -@section('header_right') -
    - @can('update', $license) - - - @endcan -
    -@stop - {{-- Page content --}} @section('content')
    @@ -78,8 +63,8 @@ @endcan From 8027039754d22149a1e540907267d7e906be72da Mon Sep 17 00:00:00 2001 From: snipe Date: Tue, 2 Aug 2022 11:48:45 -0700 Subject: [PATCH 19/27] Hide requested assets if the user cannot see requestable items Signed-off-by: snipe --- resources/views/layouts/default.blade.php | 3 +++ 1 file changed, 3 insertions(+) diff --git a/resources/views/layouts/default.blade.php b/resources/views/layouts/default.blade.php index 85ec627a2..6d27fd184 100644 --- a/resources/views/layouts/default.blade.php +++ b/resources/views/layouts/default.blade.php @@ -316,11 +316,14 @@ {{ trans('general.viewassets') }} + @can('viewRequestable', \App\Models\Asset::class)
  • {{ trans('general.requested_assets_menu') }}
  • + @endcan +
  • From 0a9bd07f209b01acb6869deaf7d1db1da5295751 Mon Sep 17 00:00:00 2001 From: snipe Date: Tue, 2 Aug 2022 12:27:58 -0700 Subject: [PATCH 20/27] Disallow checkout if qty = 0 Signed-off-by: snipe --- resources/views/consumables/view.blade.php | 19 +++++++++++++++---- 1 file changed, 15 insertions(+), 4 deletions(-) diff --git a/resources/views/consumables/view.blade.php b/resources/views/consumables/view.blade.php index cacab8b26..78728db6b 100644 --- a/resources/views/consumables/view.blade.php +++ b/resources/views/consumables/view.blade.php @@ -126,10 +126,21 @@ @endif @can('checkout', \App\Models\Consumable::class) - - @endcan + +
    + + @if ($consumable->numRemaining() > 0) + + {{ trans('general.checkout') }} + + @else + + @endif +
    + + @endcan @if ($consumable->notes) From 254ce72415b43d7f0cf933bf22875c14be72b005 Mon Sep 17 00:00:00 2001 From: snipe Date: Tue, 2 Aug 2022 17:20:51 -0700 Subject: [PATCH 21/27] Add @vickyjaura183 as a contributor --- .all-contributorsrc | 11 ++++++++++- README.md | 4 ++-- 2 files changed, 12 insertions(+), 3 deletions(-) diff --git a/.all-contributorsrc b/.all-contributorsrc index a2cfec2f9..143ca7255 100644 --- a/.all-contributorsrc +++ b/.all-contributorsrc @@ -2662,8 +2662,17 @@ "avatar_url": "https://avatars.githubusercontent.com/u/7991086?v=4", "profile": "https://github.com/reederda", "contributions": [ - "translations", "translation", + "translation", + "code" + ] + }, + { + "login": "vickyjaura183", + "name": "vickyjaura183", + "avatar_url": "https://avatars.githubusercontent.com/u/109422491?v=4", + "profile": "https://github.com/vickyjaura183", + "contributions": [ "code" ] } diff --git a/README.md b/README.md index b83894714..466c4fee6 100644 --- a/README.md +++ b/README.md @@ -1,5 +1,5 @@ ![Build Status](https://app.chipperci.com/projects/0e5f8979-31eb-4ee6-9abf-050b76ab0383/status/master) [![Crowdin](https://d322cqt584bo4o.cloudfront.net/snipe-it/localized.svg)](https://crowdin.com/project/snipe-it) [![Docker Pulls](https://img.shields.io/docker/pulls/snipe/snipe-it.svg)](https://hub.docker.com/r/snipe/snipe-it/) [![Twitter Follow](https://img.shields.io/twitter/follow/snipeitapp.svg?style=social)](https://twitter.com/snipeitapp) [![Codacy Badge](https://api.codacy.com/project/badge/Grade/553ce52037fc43ea99149785afcfe641)](https://www.codacy.com/app/snipe/snipe-it?utm_source=github.com&utm_medium=referral&utm_content=snipe/snipe-it&utm_campaign=Badge_Grade) -[![All Contributors](https://img.shields.io/badge/all_contributors-292-orange.svg?style=flat-square)](#contributors) [![Discord](https://badgen.net/badge/icon/discord?icon=discord&label)](https://discord.gg/yZFtShAcKk) [![huntr](https://cdn.huntr.dev/huntr_security_badge_mono.svg)](https://huntr.dev) +[![All Contributors](https://img.shields.io/badge/all_contributors-294-orange.svg?style=flat-square)](#contributors) [![Discord](https://badgen.net/badge/icon/discord?icon=discord&label)](https://discord.gg/yZFtShAcKk) [![huntr](https://cdn.huntr.dev/huntr_security_badge_mono.svg)](https://huntr.dev) ## Snipe-IT - Open Source Asset Management System @@ -134,7 +134,7 @@ Thanks goes to all of these wonderful people ([emoji key](https://github.com/ken | [
    Toreg87](https://github.com/Toreg87)
    [💻](https://github.com/snipe/snipe-it/commits?author=Toreg87 "Code") | [
    Matthew Nickson](https://github.com/Computroniks)
    [💻](https://github.com/snipe/snipe-it/commits?author=Computroniks "Code") | [
    Jethro Nederhof](https://jethron.id.au)
    [💻](https://github.com/snipe/snipe-it/commits?author=jethron "Code") | [
    Oskar Stenberg](https://github.com/01ste02)
    [💻](https://github.com/snipe/snipe-it/commits?author=01ste02 "Code") | [
    Robert-Azelis](https://github.com/Robert-Azelis)
    [💻](https://github.com/snipe/snipe-it/commits?author=Robert-Azelis "Code") | [
    Alexander William Smith](https://github.com/alwism)
    [💻](https://github.com/snipe/snipe-it/commits?author=alwism "Code") | [
    LEITWERK AG](https://www.leitwerk.de/)
    [💻](https://github.com/snipe/snipe-it/commits?author=leitwerk-ag "Code") | | [
    Adam](http://www.aboutcher.co.uk)
    [💻](https://github.com/snipe/snipe-it/commits?author=adamboutcher "Code") | [
    Ian](https://snksrv.com)
    [💻](https://github.com/snipe/snipe-it/commits?author=sneak-it "Code") | [
    Shao Yu-Lung (Allen)](http://blog.bestlong.idv.tw/)
    [💻](https://github.com/snipe/snipe-it/commits?author=bestlong "Code") | [
    Haxatron](https://github.com/Haxatron)
    [💻](https://github.com/snipe/snipe-it/commits?author=Haxatron "Code") | [
    PlaneNuts](https://github.com/PlaneNuts)
    [💻](https://github.com/snipe/snipe-it/commits?author=PlaneNuts "Code") | [
    Bradley Coudriet](http://bjcpgd.cias.rit.edu)
    [💻](https://github.com/snipe/snipe-it/commits?author=exula "Code") | [
    Dalton Durst](https://daltondur.st)
    [💻](https://github.com/snipe/snipe-it/commits?author=UniversalSuperBox "Code") | | [
    Alex Janes](https://adagiohealth.org)
    [💻](https://github.com/snipe/snipe-it/commits?author=adagioajanes "Code") | [
    Nuraeil](https://github.com/nuraeil)
    [💻](https://github.com/snipe/snipe-it/commits?author=nuraeil "Code") | [
    TenOfTens](https://github.com/TenOfTens)
    [💻](https://github.com/snipe/snipe-it/commits?author=TenOfTens "Code") | [
    waffle](https://ditisjens.be/)
    [💻](https://github.com/snipe/snipe-it/commits?author=insert-waffle "Code") | [
    Yevhenii Huzii](https://github.com/QveenSi)
    [💻](https://github.com/snipe/snipe-it/commits?author=QveenSi "Code") | [
    Achmad Fienan Rahardianto](https://github.com/veenone)
    [💻](https://github.com/snipe/snipe-it/commits?author=veenone "Code") | [
    Yevhenii Huzii](https://github.com/QveenSi)
    [💻](https://github.com/snipe/snipe-it/commits?author=QveenSi "Code") | -| [
    Christian Weirich](https://github.com/chrisweirich)
    [💻](https://github.com/snipe/snipe-it/commits?author=chrisweirich "Code") | [
    denzfarid](https://github.com/denzfarid)
    | [
    ntbutler-nbcs](https://github.com/ntbutler-nbcs)
    [💻](https://github.com/snipe/snipe-it/commits?author=ntbutler-nbcs "Code") | [
    Naveen](https://naveensrinivasan.dev)
    [💻](https://github.com/snipe/snipe-it/commits?author=naveensrinivasan "Code") | [
    Mike Roquemore](https://github.com/mikeroq)
    [💻](https://github.com/snipe/snipe-it/commits?author=mikeroq "Code") | +| [
    Christian Weirich](https://github.com/chrisweirich)
    [💻](https://github.com/snipe/snipe-it/commits?author=chrisweirich "Code") | [
    denzfarid](https://github.com/denzfarid)
    | [
    ntbutler-nbcs](https://github.com/ntbutler-nbcs)
    [💻](https://github.com/snipe/snipe-it/commits?author=ntbutler-nbcs "Code") | [
    Naveen](https://naveensrinivasan.dev)
    [💻](https://github.com/snipe/snipe-it/commits?author=naveensrinivasan "Code") | [
    Mike Roquemore](https://github.com/mikeroq)
    [💻](https://github.com/snipe/snipe-it/commits?author=mikeroq "Code") | [
    Daniel Reeder](https://github.com/reederda)
    [🌍](#translation-reederda "Translation") [🌍](#translation-reederda "Translation") [💻](https://github.com/snipe/snipe-it/commits?author=reederda "Code") | [
    vickyjaura183](https://github.com/vickyjaura183)
    [💻](https://github.com/snipe/snipe-it/commits?author=vickyjaura183 "Code") | This project follows the [all-contributors](https://github.com/kentcdodds/all-contributors) specification. Contributions of any kind welcome! From 8e18ce74b25aab169981f7ae0cab9906309c85e1 Mon Sep 17 00:00:00 2001 From: snipe Date: Tue, 2 Aug 2022 19:12:18 -0700 Subject: [PATCH 22/27] Update method name Signed-off-by: snipe --- app/Http/Controllers/ReportsController.php | 2 +- app/Presenters/AssetPresenter.php | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/app/Http/Controllers/ReportsController.php b/app/Http/Controllers/ReportsController.php index 52032114e..06629c175 100644 --- a/app/Http/Controllers/ReportsController.php +++ b/app/Http/Controllers/ReportsController.php @@ -789,7 +789,7 @@ class ReportsController extends Controller if ($request->filled('warranty')) { $row[] = ($asset->warranty_months) ? $asset->warranty_months : ''; - $row[] = $asset->present()->warrantee_expires(); + $row[] = $asset->present()->warranty_expires(); } if ($request->filled('depreciation')) { diff --git a/app/Presenters/AssetPresenter.php b/app/Presenters/AssetPresenter.php index f334906c8..e54f9d559 100644 --- a/app/Presenters/AssetPresenter.php +++ b/app/Presenters/AssetPresenter.php @@ -501,7 +501,7 @@ class AssetPresenter extends Presenter * Date the warantee expires. * @return false|string */ - public function warrantee_expires() + public function warranty_expires() { if (($this->purchase_date) && ($this->warranty_months)) { $date = date_create($this->purchase_date); From ac72b69ece8779dd6d6001349eef458cf4689289 Mon Sep 17 00:00:00 2001 From: snipe Date: Tue, 2 Aug 2022 19:12:28 -0700 Subject: [PATCH 23/27] Update method name Signed-off-by: snipe --- app/Presenters/DepreciationReportPresenter.php | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/app/Presenters/DepreciationReportPresenter.php b/app/Presenters/DepreciationReportPresenter.php index 525552a64..ea8834237 100644 --- a/app/Presenters/DepreciationReportPresenter.php +++ b/app/Presenters/DepreciationReportPresenter.php @@ -371,7 +371,7 @@ class DepreciationReportPresenter extends Presenter * Date the warantee expires. * @return false|string */ - public function warrantee_expires() + public function warranty_expires() { if (($this->purchase_date) && ($this->warranty_months)) { $date = date_create($this->purchase_date); From 10e64deafebd79822f7ddaf1be1383c9fa372503 Mon Sep 17 00:00:00 2001 From: snipe Date: Tue, 2 Aug 2022 19:12:44 -0700 Subject: [PATCH 24/27] Updated method name in mail Signed-off-by: snipe --- .../notifications/markdown/report-expiring-assets.blade.php | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/resources/views/notifications/markdown/report-expiring-assets.blade.php b/resources/views/notifications/markdown/report-expiring-assets.blade.php index b5a262903..4311096a6 100644 --- a/resources/views/notifications/markdown/report-expiring-assets.blade.php +++ b/resources/views/notifications/markdown/report-expiring-assets.blade.php @@ -6,8 +6,8 @@  {{ trans('mail.name') }}{{ trans('mail.Days') }}{{ trans('mail.expires') }}{{ trans('mail.supplier') }}{{ trans('mail.assigned_to') }} @foreach ($assets as $asset) @php -$expires = Helper::getFormattedDateObject($asset->present()->warrantee_expires, 'date'); -$diff = round(abs(strtotime($asset->present()->warrantee_expires) - strtotime(date('Y-m-d')))/86400); +$expires = Helper::getFormattedDateObject($asset->present()->warranty_expires, 'date'); +$diff = round(abs(strtotime($asset->present()->warranty_expires) - strtotime(date('Y-m-d')))/86400); $icon = ($diff <= ($threshold / 2)) ? '🚨' : (($diff <= $threshold) ? '⚠️' : ' '); @endphp {{ $icon }} {{ $asset->present()->name }} {{ $diff }} {{ trans('mail.Days') }} {{ $expires['formatted'] }} {{ ($asset->supplier ? e($asset->supplier->name) : '') }} {{ ($asset->assignedTo ? e($asset->assignedTo->present()->name()) : '') }} From 56b69045646e5c61b8b83b35cb7f440e9c498f60 Mon Sep 17 00:00:00 2001 From: snipe Date: Tue, 2 Aug 2022 19:13:02 -0700 Subject: [PATCH 25/27] Added time difference Signed-off-by: snipe --- resources/views/hardware/view.blade.php | 51 ++++++++++++------------- 1 file changed, 25 insertions(+), 26 deletions(-) diff --git a/resources/views/hardware/view.blade.php b/resources/views/hardware/view.blade.php index a1452767d..d08b9e562 100755 --- a/resources/views/hardware/view.blade.php +++ b/resources/views/hardware/view.blade.php @@ -574,7 +574,7 @@ @if ($asset->warranty_months) -
    +
    {{ trans('admin/hardware/form.warranty') }} @@ -584,10 +584,24 @@ {{ $asset->warranty_months }} {{ trans('admin/hardware/form.months') }} - ({{ trans('admin/hardware/form.expires') }} - {{ $asset->present()->warrantee_expires() }}) +
    + +
    +
    + + {{ trans('admin/hardware/form.warranty_expires') }} + +
    +
    + {{ Helper::getFormattedDateObject($asset->present()->warranty_expires(), 'date', false) }} + - + {{ Carbon::parse($asset->present()->warranty_expires())->diffForHumans() }} + +
    +
    + @endif @if (($asset->model) && ($asset->depreciation)) @@ -600,8 +614,7 @@
    {{ $asset->depreciation->name }} ({{ $asset->depreciation->months }} - {{ trans('admin/hardware/form.months') }} - ) + {{ trans('admin/hardware/form.months') }})
    @@ -611,13 +624,10 @@
    - @if ($asset->time_until_depreciated()->y > 0) - {{ $asset->time_until_depreciated()->y }} - {{ trans('admin/hardware/form.years') }}, - @endif - {{ $asset->time_until_depreciated()->m }} - {{ trans('admin/hardware/form.months') }} - ({{ $asset->depreciated_date()->format('Y-m-d') }}) + {{ Helper::getFormattedDateObject($asset->depreciated_date()->format('Y-m-d'), 'date', false) }} + - + {{ Carbon::parse($asset->depreciated_date())->diffForHumans() }} +
  • @endif @@ -644,20 +654,9 @@
    {{ Helper::getFormattedDateObject($asset->present()->eol_date(), 'date', false) }} - - - @if ($asset->present()->months_until_eol()) - - - @if ($asset->present()->months_until_eol()->y > 0) - {{ $asset->present()->months_until_eol()->y }} - {{ trans('general.years') }}, - @endif - - {{ $asset->present()->months_until_eol()->m }} - {{ trans('general.months') }} - - @endif - + - + {{ Carbon::parse($asset->present()->eol_date())->diffForHumans() }} +
    @endif From da1c1dbdd9316d12a37fce98187247358ff60941 Mon Sep 17 00:00:00 2001 From: snipe Date: Tue, 2 Aug 2022 19:19:08 -0700 Subject: [PATCH 26/27] Added warning icon Signed-off-by: snipe --- resources/views/hardware/view.blade.php | 6 ++++-- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/resources/views/hardware/view.blade.php b/resources/views/hardware/view.blade.php index d08b9e562..bcc862990 100755 --- a/resources/views/hardware/view.blade.php +++ b/resources/views/hardware/view.blade.php @@ -574,7 +574,7 @@ @if ($asset->warranty_months) -
    +
    {{ trans('admin/hardware/form.warranty') }} @@ -588,13 +588,15 @@
    -
    +
    {{ trans('admin/hardware/form.warranty_expires') }} + {!! $asset->present()->warranty_expires() < date("Y-m-d") ? '' : '' !!}
    + {{ Helper::getFormattedDateObject($asset->present()->warranty_expires(), 'date', false) }} - {{ Carbon::parse($asset->present()->warranty_expires())->diffForHumans() }} From 87bed9b294156e9766881659fe49c73eacf7e631 Mon Sep 17 00:00:00 2001 From: snipe Date: Tue, 2 Aug 2022 19:24:46 -0700 Subject: [PATCH 27/27] Fixed typo in code comments Signed-off-by: snipe --- app/Presenters/AssetPresenter.php | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/app/Presenters/AssetPresenter.php b/app/Presenters/AssetPresenter.php index e54f9d559..bd03f29a1 100644 --- a/app/Presenters/AssetPresenter.php +++ b/app/Presenters/AssetPresenter.php @@ -498,7 +498,7 @@ class AssetPresenter extends Presenter } /** - * Date the warantee expires. + * Date the warranty expires. * @return false|string */ public function warranty_expires()