diff --git a/app/Http/Controllers/Accessories/AccessoriesFilesController.php b/app/Http/Controllers/Accessories/AccessoriesFilesController.php index cc6dcfb97..ef701020d 100644 --- a/app/Http/Controllers/Accessories/AccessoriesFilesController.php +++ b/app/Http/Controllers/Accessories/AccessoriesFilesController.php @@ -27,10 +27,16 @@ class AccessoriesFilesController extends Controller */ public function store(AssetFileRequest $request, $accessoryId = null) { + + if (config('app.lock_passwords')) { + return redirect()->route('accessories.show', ['accessory'=>$accessoryId])->with('error', trans('general.feature_disabled')); + } + + $accessory = Accessory::find($accessoryId); if (isset($accessory->id)) { - $this->authorize('update', $accessory); + $this->authorize('accessories.files', $accessory); if ($request->hasFile('file')) { if (! Storage::exists('private_uploads/accessories')) { @@ -129,9 +135,12 @@ class AccessoriesFilesController extends Controller */ public function show($accessoryId = null, $fileId = null, $download = true) { + \Log::debug('Private filesystem is: '.config('filesystems.default')); $accessory = Accessory::find($accessoryId); + + // the accessory is valid if (isset($accessory->id)) { $this->authorize('view', $accessory); diff --git a/app/Http/Controllers/AssetModelsFilesController.php b/app/Http/Controllers/AssetModelsFilesController.php index 5064027ff..a68ef482c 100644 --- a/app/Http/Controllers/AssetModelsFilesController.php +++ b/app/Http/Controllers/AssetModelsFilesController.php @@ -62,7 +62,7 @@ class AssetModelsFilesController extends Controller $model->logUpload($file_name, e($request->get('notes'))); } - return redirect()->back()->with('success', trans('admin/hardware/message.upload.success')); + return redirect()->back()->with('success', trans('general.file_upload_success')); } return redirect()->back()->with('error', trans('admin/hardware/message.upload.nofiles')); diff --git a/app/Http/Controllers/Components/ComponentsFilesController.php b/app/Http/Controllers/Components/ComponentsFilesController.php index d9f59f1d9..3fc93b74e 100644 --- a/app/Http/Controllers/Components/ComponentsFilesController.php +++ b/app/Http/Controllers/Components/ComponentsFilesController.php @@ -27,6 +27,11 @@ class ComponentsFilesController extends Controller */ public function store(AssetFileRequest $request, $componentId = null) { + + if (config('app.lock_passwords')) { + return redirect()->route('components.show', ['component'=>$componentId])->with('error', trans('general.feature_disabled')); + } + $component = Component::find($componentId); if (isset($component->id)) { diff --git a/app/Http/Controllers/Consumables/ConsumablesFilesController.php b/app/Http/Controllers/Consumables/ConsumablesFilesController.php index 51c0d3bf8..9b4007a43 100644 --- a/app/Http/Controllers/Consumables/ConsumablesFilesController.php +++ b/app/Http/Controllers/Consumables/ConsumablesFilesController.php @@ -27,6 +27,10 @@ class ConsumablesFilesController extends Controller */ public function store(AssetFileRequest $request, $consumableId = null) { + if (config('app.lock_passwords')) { + return redirect()->route('consumables.show', ['consumable'=>$consumableId])->with('error', trans('general.feature_disabled')); + } + $consumable = Consumable::find($consumableId); if (isset($consumable->id)) { diff --git a/resources/views/accessories/view.blade.php b/resources/views/accessories/view.blade.php index 82ff8efc4..2bccb40a9 100644 --- a/resources/views/accessories/view.blade.php +++ b/resources/views/accessories/view.blade.php @@ -72,7 +72,7 @@ - @can('accessorys.files', $accessory) + @can('accessories.files', $accessory)
  • @@ -198,7 +198,7 @@ data-sort-name="name" class="table table-striped snipe-table" data-export-options='{ - "fileName": "export-accessorys-uploads-{{ str_slug($accessory->name) }}-{{ date('Y-m-d') }}", + "fileName": "export-accessories-uploads-{{ str_slug($accessory->name) }}-{{ date('Y-m-d') }}", "ignoreColumn": ["actions","image","change","checkbox","checkincheckout","delete","download","icon"] }'> @@ -224,7 +224,7 @@ @if ($file->filename) - @if ( Helper::checkUploadIsImage($file->get_src('accessorys'))) + @if ( Helper::checkUploadIsImage($file->get_src('accessories'))) @endif @endif @@ -232,8 +232,8 @@ {{ $file->filename }} - - {{ @Helper::formatFilesizeUnits(Storage::exists('private_uploads/accessorys/'.$file->filename) ? Storage::size('private_uploads/accessorys/'.$file->filename) : '') }} + + {{ @Helper::formatFilesizeUnits(Storage::exists('private_uploads/accessories/'.$file->filename) ? Storage::size('private_uploads/accessories/'.$file->filename) : '') }} @@ -392,7 +392,7 @@ -@can('update', Accessory::class) +@can('accessories.files', Accessory::class) @include ('modals.upload-file', ['item_type' => 'accessory', 'item_id' => $accessory->id]) @endcan @stop diff --git a/resources/views/components/view.blade.php b/resources/views/components/view.blade.php index d7b494566..2f6a30208 100644 --- a/resources/views/components/view.blade.php +++ b/resources/views/components/view.blade.php @@ -283,7 +283,7 @@
    -@can('update', Component::class) +@can('components.files', Component::class) @include ('modals.upload-file', ['item_type' => 'component', 'item_id' => $component->id]) @endcan @stop diff --git a/resources/views/consumables/view.blade.php b/resources/views/consumables/view.blade.php index 406d3b4bd..90d27cff1 100644 --- a/resources/views/consumables/view.blade.php +++ b/resources/views/consumables/view.blade.php @@ -288,7 +288,7 @@ -@can('update', \App\Models\Consumable::class) +@can('consumables.files', \App\Models\Consumable::class) @include ('modals.upload-file', ['item_type' => 'consumable', 'item_id' => $consumable->id]) @endcan @stop diff --git a/resources/views/models/view.blade.php b/resources/views/models/view.blade.php index 278b6a78f..fe6ab3d0c 100755 --- a/resources/views/models/view.blade.php +++ b/resources/views/models/view.blade.php @@ -145,9 +145,9 @@ - @if ( Helper::checkUploadIsImage($file->get_src('assets'))) - - + @if ( Helper::checkUploadIsImage($file->get_src('assetmodels'))) + + @endif