diff --git a/app/Http/Controllers/Api/AssetsController.php b/app/Http/Controllers/Api/AssetsController.php index 85373833a..cc04207b8 100644 --- a/app/Http/Controllers/Api/AssetsController.php +++ b/app/Http/Controllers/Api/AssetsController.php @@ -54,7 +54,7 @@ class AssetsController extends Controller { \Log::debug(Route::currentRouteName()); - + $filter_non_deprecable_assets = false; /** * This looks MAD janky (and it is), but the AssetsController@index does a LOT of heavy lifting throughout the @@ -68,6 +68,7 @@ class AssetsController extends Controller * which would have been far worse of a mess. *sad face* - snipe (Sept 1, 2021) */ if (Route::currentRouteName()=='api.depreciation-report.index') { + $filter_non_deprecable_assets = true; $transformer = 'App\Http\Transformers\DepreciationReportTransformer'; $this->authorize('reports.view'); } else { @@ -118,6 +119,12 @@ class AssetsController extends Controller 'model.category', 'model.manufacturer', 'model.fieldset','supplier'); //it might be tempting to add 'assetlog' here, but don't. It blows up update-heavy users. + if($filter_non_deprecable_assets) { + $non_deprecable_models = AssetModel::select('id')->whereNotNull('depreciation_id')->get(); + + $assets->InModelList($non_deprecable_models->toArray()); + } + // These are used by the API to query against specific ID numbers. // They are also used by the individual searches on detail pages like // locations, etc. diff --git a/resources/views/models/edit.blade.php b/resources/views/models/edit.blade.php index 436e42517..ee299cdde 100755 --- a/resources/views/models/edit.blade.php +++ b/resources/views/models/edit.blade.php @@ -34,7 +34,9 @@ -@livewire('custom-field-set-default-values-for-model',["model_id" => $item->id]) +@if (isset($item->id)) + @livewire('custom-field-set-default-values-for-model',["model_id" => $item->id]) +@endif @include ('partials.forms.edit.notes') @include ('partials.forms.edit.requestable', ['requestable_text' => trans('admin/models/general.requestable')]) diff --git a/routes/api.php b/routes/api.php index 508358f3d..52900baad 100644 --- a/routes/api.php +++ b/routes/api.php @@ -296,7 +296,7 @@ Route::group(['prefix' => 'v1', 'middleware' => 'api'], function () { ); // end depreciations API routes - Route::post('reports/depreciation', + Route::get('reports/depreciation', [ Api\AssetsController::class, 'index'