From 4cdcbc97eea279592b4fb5eb27424f0fa926c150 Mon Sep 17 00:00:00 2001 From: snipe Date: Wed, 1 Nov 2017 13:10:56 -0700 Subject: [PATCH 1/2] Fixed varname issue on old image delete for manufacturers --- app/Http/Controllers/ManufacturersController.php | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/app/Http/Controllers/ManufacturersController.php b/app/Http/Controllers/ManufacturersController.php index 5d058f501..7bd6858b1 100755 --- a/app/Http/Controllers/ManufacturersController.php +++ b/app/Http/Controllers/ManufacturersController.php @@ -142,7 +142,7 @@ class ManufacturersController extends Controller $image = $request->file('image'); $file_name = str_slug($image->getClientOriginalName()).".".$image->getClientOriginalExtension(); $path = public_path('uploads/manufacturers/'.$file_name); - $old_image = $path.$model->image; + $old_image = $path.$manufacturer->image; try { unlink($old_image); From d36e8cfbd25a375b37615ed0a76b80d0ca39a9e8 Mon Sep 17 00:00:00 2001 From: snipe Date: Wed, 1 Nov 2017 13:27:59 -0700 Subject: [PATCH 2/2] Dashbpoard pie fixes --- .../Controllers/Api/StatuslabelsController.php | 17 ++++++++++------- 1 file changed, 10 insertions(+), 7 deletions(-) diff --git a/app/Http/Controllers/Api/StatuslabelsController.php b/app/Http/Controllers/Api/StatuslabelsController.php index 9860beea2..5bc65d020 100644 --- a/app/Http/Controllers/Api/StatuslabelsController.php +++ b/app/Http/Controllers/Api/StatuslabelsController.php @@ -161,19 +161,22 @@ class StatuslabelsController extends Controller public function getAssetCountByStatuslabel() { - $statusLabels = Statuslabel::get(); + $statuslabels = Statuslabel::with('assets')->groupBy('id')->withCount('assets')->get(); + $labels=[]; $points=[]; $colors=[]; - foreach ($statusLabels as $statusLabel) { - if ($statusLabel->assets()->count() > 0) { - $labels[]=$statusLabel->name; - $points[]=$statusLabel->assets()->whereNull('assigned_to')->count(); - if ($statusLabel->color!='') { - $colors[]=$statusLabel->color; + foreach ($statuslabels as $statuslabel) { + if ($statuslabel->assets_count > 0) { + + $labels[]=$statuslabel->name. ' ('.number_format($statuslabel->assets_count).')'; + $points[]=$statuslabel->assets_count; + if ($statuslabel->color!='') { + $colors[]=$statuslabel->color; } } } + $colors_array = array_merge($colors, Helper::chartColors());