lunax/snipe_it
1
0
Fork 0
Code Issues Pull requests Projects Releases Wiki Activity Actions

Merge pull request #16553 from marcusmoore/tests/user-show

Browse source 
Added tests around emailing and printing assigned assets
This commit is contained in:
snipe 2025-04-08 06:48:39 +01:00 • committed by GitHub
commit d44553c6dd
No known key found for this signature in database
GPG key ID: B5690EEEBB952194
3 changed files with 106 additions and 67 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

40
tests/Feature/Users/Ui/EmailAssignedToUserTest.php Normal file
View file

@ -0,0 +1,40 @@
<?php
namespace Tests\Feature\Users\Ui;
use App\Models\Company;
use App\Models\User;
use App\Notifications\CurrentInventory;
use Illuminate\Support\Facades\Notification;
use Tests\TestCase;
class EmailAssignedToUserTest extends TestCase
{
public function testUserWithoutCompanyPermissionsCannotSendInventory()
{
Notification::fake();
$this->settings->enableMultipleFullCompanySupport();
[$companyA, $companyB] = Company::factory()->count(2)->create();
$superuser = User::factory()->superuser()->create();
$user = User::factory()->for($companyB)->create();
$this->actingAs(User::factory()->viewUsers()->for($companyA)->create())
->post(route('users.email', ['userId' => $user->id]))
->assertStatus(403);
$this->actingAs(User::factory()->viewUsers()->for($companyB)->create())
->post(route('users.email', ['userId' => $user->id]))
->assertStatus(302);
$this->actingAs($superuser)
->post(route('users.email', ['userId' => $user->id]))
->assertStatus(302);
Notification::assertSentTo(
[$user], CurrentInventory::class
);
}
}

41
tests/Feature/Users/Ui/PrintUserInventoryTest.php Normal file
View file

@ -0,0 +1,41 @@
<?php
namespace Tests\Feature\Users\Ui;
use App\Models\Company;
use App\Models\User;
use Tests\TestCase;
class PrintUserInventoryTest extends TestCase
{
public function testPermissionRequiredToPrintUserInventory()
{
$this->actingAs(User::factory()->create())
->get(route('users.print', User::factory()->create()))
->assertStatus(403);
}
public function testCanPrintUserInventory()
{
$actor = User::factory()->viewUsers()->create();
$this->actingAs($actor)
->get(route('users.print', User::factory()->create()))
->assertOk()
->assertStatus(200);
}
public function testCannotPrintUserInventoryFromAnotherCompany()
{
$this->settings->enableMultipleFullCompanySupport();
[$companyA, $companyB] = Company::factory()->count(2)->create();
$actor = User::factory()->for($companyA)->viewUsers()->create();
$user = User::factory()->for($companyB)->create();
$this->actingAs($actor)
->get(route('users.print', $user))
->assertStatus(302);
}
}

92
tests/Feature/Users/Ui/ViewUserTest.php
View file

@ -4,80 +4,38 @@ namespace Tests\Feature\Users\Ui;
use App\Models\Company;
use App\Models\User;
use App\Notifications\CurrentInventory;
use Illuminate\Support\Facades\Notification;
use Tests\TestCase;
class ViewUserTest extends TestCase
{
public function testPermissionsForUserDetailPage()
public function testRequiresPermissionToViewUser()
{
$this->settings->enableMultipleFullCompanySupport();
[$companyA, $companyB] = Company::factory()->count(2)->create();
$superuser = User::factory()->superuser()->create();
$user = User::factory()->for($companyB)->create();
$this->actingAs(User::factory()->editUsers()->for($companyA)->create())
->get(route('users.show', $user))
->assertStatus(302);
$this->actingAs($superuser)
->get(route('users.show', $user))
->assertOk()
->assertStatus(200);
}
public function testPermissionsForPrintAllInventoryPage()
{
$this->settings->enableMultipleFullCompanySupport();
[$companyA, $companyB] = Company::factory()->count(2)->create();
$superuser = User::factory()->superuser()->create();
$user = User::factory()->for($companyB)->create();
$this->actingAs(User::factory()->viewUsers()->for($companyA)->create())
->get(route('users.print', ['userId' => $user->id]))
->assertStatus(302);
$this->actingAs(User::factory()->viewUsers()->for($companyB)->create())
->get(route('users.print', ['userId' => $user->id]))
->assertStatus(200);
$this->actingAs($superuser)
->get(route('users.print', ['userId' => $user->id]))
->assertOk()
->assertStatus(200);
}
public function testUserWithoutCompanyPermissionsCannotSendInventory()
{
Notification::fake();
$this->settings->enableMultipleFullCompanySupport();
[$companyA, $companyB] = Company::factory()->count(2)->create();
$superuser = User::factory()->superuser()->create();
$user = User::factory()->for($companyB)->create();
$this->actingAs(User::factory()->viewUsers()->for($companyA)->create())
->post(route('users.email', ['userId' => $user->id]))
$this->actingAs(User::factory()->create())
->get(route('users.show', User::factory()->create()))
->assertStatus(403);
}
$this->actingAs(User::factory()->viewUsers()->for($companyB)->create())
->post(route('users.email', ['userId' => $user->id]))
public function testCanViewUser()
{
$actor = User::factory()->viewUsers()->create();
$this->actingAs($actor)
->get(route('users.show', User::factory()->create()))
->assertOk()
->assertStatus(200);
}
public function testCannotViewUserFromAnotherCompany()
{
$this->settings->enableMultipleFullCompanySupport();
[$companyA, $companyB] = Company::factory()->count(2)->create();
$actor = User::factory()->for($companyA)->viewUsers()->create();
$user = User::factory()->for($companyB)->create();
$this->actingAs($actor)
->get(route('users.show', $user))
->assertStatus(302);
$this->actingAs($superuser)
->post(route('users.email', ['userId' => $user->id]))
->assertStatus(302);
Notification::assertSentTo(
[$user], CurrentInventory::class
);
}
}