lunax/snipe_it
1
0
Fork 0
Code Issues Pull requests Projects Releases Wiki Activity Actions

Improve try catch blocks

Browse source
This commit is contained in:
Marcus Moore 2023-10-10 15:18:37 -07:00
parent 9ef598d07b
commit dae9e6d096
1 changed files with 11 additions and 13 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

24
app/Listeners/CheckoutableListener.php
View file

@ -42,7 +42,7 @@ class CheckoutableListener
/** /**
* Make a checkout acceptance and attach it in the notification * Make a checkout acceptance and attach it in the notification
*/ */
$acceptance = $this->getCheckoutAcceptance($event); $acceptance = $this->getCheckoutAcceptance($event);
try { try {
if (! $event->checkedOutTo->locale) { if (! $event->checkedOutTo->locale) {
@ -61,12 +61,11 @@ class CheckoutableListener
Notification::route('slack', Setting::getSettings()->webhook_endpoint) Notification::route('slack', Setting::getSettings()->webhook_endpoint)
->notify($this->getCheckoutNotification($event)); ->notify($this->getCheckoutNotification($event));
} }
} catch (Exception $e) { }
if ($e instanceof ClientException){ catch (ClientException $e){
Log::debug("Exception caught during checkout notification: ".$e->getMessage()); Log::debug("Exception caught during checkout notification: ".$e->getMessage());
return; }
} catch (Exception $e) {
Log::error("Exception caught during checkout notification: ".$e->getMessage()); Log::error("Exception caught during checkout notification: ".$e->getMessage());
} }
} }
@ -115,12 +114,11 @@ class CheckoutableListener
Notification::route('slack', Setting::getSettings()->webhook_endpoint) Notification::route('slack', Setting::getSettings()->webhook_endpoint)
->notify($this->getCheckinNotification($event)); ->notify($this->getCheckinNotification($event));
} }
} catch (Exception $e) { }
if ($e instanceof ClientException){ catch (ClientException $e){
Log::debug("Exception caught during checkout notification: ".$e->getMessage()); Log::debug("Exception caught during checkout notification: ".$e->getMessage());
return; }
} catch (Exception $e) {
Log::error("Exception caught during checkin notification: ".$e->getMessage()); Log::error("Exception caught during checkin notification: ".$e->getMessage());
} }
} }