From 0396267388086adb39fd164b5fc8b0afc9c70858 Mon Sep 17 00:00:00 2001
From: snipe <snipe@snipe.net>
Date: Sun, 12 Nov 2017 17:22:16 -0800
Subject: [PATCH 1/2] Fixed #4412 - use select2 ajax list for asset
 maintenances

---
 .../AssetMaintenancesController.php            | 13 +++++++++----
 .../views/asset_maintenances/edit.blade.php    | 18 ++----------------
 .../partials/forms/edit/asset-select.blade.php |  3 ++-
 3 files changed, 13 insertions(+), 21 deletions(-)

diff --git a/app/Http/Controllers/AssetMaintenancesController.php b/app/Http/Controllers/AssetMaintenancesController.php
index f7041f38e..3b9840b4f 100644
--- a/app/Http/Controllers/AssetMaintenancesController.php
+++ b/app/Http/Controllers/AssetMaintenancesController.php
@@ -154,16 +154,21 @@ class AssetMaintenancesController extends Controller
      */
     public function create()
     {
+        $asset = null;
+
+        if ($asset = Asset::find(request('asset_id'))) {
+            // We have to set this so that the correct property is set in the select2 ajax dropdown
+            $asset->asset_id = $asset->id;
+        }
+
         // Prepare Asset Maintenance Type List
         $assetMaintenanceType = [
                                     '' => 'Select an asset maintenance type',
                                 ] + AssetMaintenance::getImprovementOptions();
         // Mark the selected asset, if it came in
-        // Render the view
+
         return view('asset_maintenances/edit')
-                   ->with('asset_list', Helper::detailedAssetList())
-                   ->with('selectedAsset', request('asset_id'))
-                   ->with('supplier_list', Helper::suppliersList())
+                   ->with('asset', $asset)
                    ->with('assetMaintenanceType', $assetMaintenanceType)
                    ->with('item', new AssetMaintenance);
     }
diff --git a/resources/views/asset_maintenances/edit.blade.php b/resources/views/asset_maintenances/edit.blade.php
index df7737c0f..09fdb92f0 100644
--- a/resources/views/asset_maintenances/edit.blade.php
+++ b/resources/views/asset_maintenances/edit.blade.php
@@ -41,22 +41,8 @@
       </div><!-- /.box-header -->
 
       <div class="box-body">
-        <!-- Asset -->
-        <div class="form-group {{ $errors->has('asset_id') ? ' has-error' : '' }}">
-          <label for="asset_id" class="col-md-3 control-label">
-            {{ trans('admin/asset_maintenances/table.asset_name') }}
-          </label>
-          <div class="col-md-7{{  (\App\Helpers\Helper::checkIfRequired($item, 'asset_id')) ? ' required' : '' }}">
-            @if ($selectedAsset == null)
-            {{ Form::select('asset_id', $asset_list , Input::old('asset_id', $item->asset_id), ['class'=>'select2', 'style'=>'min-width:350px']) }}
-            @else
-            {{ Form::select('asset_id', $asset_list , Input::old('asset_id', $selectedAsset), ['class'=>'select2', 'style'=>'min-width:350px', 'enabled' => 'false']) }}
-            @endif
-            {!! $errors->first('asset_id', '<span class="alert-msg"><i class="fa fa-times"></i> :message</span>') !!}
-          </div>
-        </div> <!-- .form-group -->
-
-        @include ('partials.forms.edit.supplier')
+        @include ('partials.forms.edit.asset-select', ['translated_name' => trans('admin/asset_maintenances/table.asset_name'), 'fieldname' => 'asset_id'])
+        @include ('partials.forms.edit.supplier-select', ['translated_name' => trans('general.supplier'), 'fieldname' => 'supplier_id'])
         @include ('partials.forms.edit.maintenance_type')
 
         <!-- Title -->
diff --git a/resources/views/partials/forms/edit/asset-select.blade.php b/resources/views/partials/forms/edit/asset-select.blade.php
index 1f0c732a6..5c9e67199 100644
--- a/resources/views/partials/forms/edit/asset-select.blade.php
+++ b/resources/views/partials/forms/edit/asset-select.blade.php
@@ -3,7 +3,8 @@
     {{ Form::label($fieldname, $translated_name, array('class' => 'col-md-3 control-label')) }}
     <div class="col-md-7 required">
         <select class="js-data-ajax select2" data-endpoint="hardware" name="{{ $fieldname }}" style="width: 100%" id="assigned_asset_select"{{ (isset($multiple)) ? ' multiple="multiple"' : '' }}>
-            @if ($asset_id = Input::old($fieldname, (isset($item)) ? $item->{$fieldname} : ''))
+
+            @if ($asset_id = Input::old($fieldname, (isset($asset) ? $asset->id  : (isset($item) ? $item->{$fieldname} : ''))))
                 <option value="{{ $asset_id }}" selected="selected">
                     {{ (\App\Models\Asset::find($asset_id)) ? \App\Models\Asset::find($asset_id)->present()->fullName : '' }}
                 </option>

From 3e5e6ba99a931079b355f771ffefea99da7fd20d Mon Sep 17 00:00:00 2001
From: snipe <snipe@snipe.net>
Date: Tue, 14 Nov 2017 00:04:03 -0800
Subject: [PATCH 2/2] Use table alias for models join in search/order by models

---
 app/Models/Asset.php | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/app/Models/Asset.php b/app/Models/Asset.php
index 3ef3f1483..df95964d3 100644
--- a/app/Models/Asset.php
+++ b/app/Models/Asset.php
@@ -963,7 +963,7 @@ class Asset extends Depreciable
     */
     public function scopeOrderModels($query, $order)
     {
-        return $query->join('models', 'assets.model_id', '=', 'models.id')->orderBy('models.name', $order);
+        return $query->join('models as asset_models', 'assets.model_id', '=', 'models.id')->orderBy('models.name', $order);
     }
 
     /**